Repository navigation
Conversation
On a slow CI runner the relay test's recording came out with too few frames (74 and 131 of the 144 expected, in two of three macOS runs). The test stopped before its guest left, so the guest kept a slot; the 16-guest test then counted 15, left its 15 sockets open, and the LAN guest after it was refused (timeout). The relay, 16-guest and LAN tests now always clean up. Both the WebRTC guest test and the relay test now print the frame count of a recording with that guest on stage, to tell slow runners apart from a cost of the relay itself. A frame whose write to the relayed guest's track is rejected (the track stopped) is now closed instead of left to the garbage collector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1 was merged, the macOS browser job on
mainfailed in two of three runs (41875500580, and41877336978on #4);41877365558, the same code, passed.What failed
a guest with no direct path joins through the relay: the recording with the relayed guest on stage had 74 and 131 video frames, under the 144 (6 s × 30 fps × 0.8) the check expects. The runners are slow today: the first recording test took 29–47 s against 15.6 s in October.no more than 16 guests can jointhen counted 15 and left its sockets open, so the room was full and the LAN guest inguests on the local network join over HTTPSwas refused (timeout).no uncaught errorscaught a "VideoFrame was garbage collected" warning.Changes
finally. Checked locally by forcing the relay test to fail: the other 20 tests pass.note:lines, no new assertion). On CI this tells a slow runner (both low) from a cost of the relay itself (only the relay low). The frame threshold is unchanged until that data is in.relayFramecloses a frame whose write to the track is rejected (the track stopped while a write was pending).All 21 browser tests pass locally (both recordings: 183 frames in 6 s).
🤖 Generated with Claude Code