Skip to content

ci: remove blocked mobile job and preserve patched Expo versions - #346

Merged
bk-agent-01 merged 3 commits into
stagefrom
fix/remove-mobile-native-ci
Oct 23, 2026
Merged

bk-agent-01 merged 3 commits into
stagefrom
fix/remove-mobile-native-ci

Conversation

@bk-agent-01

@bk-agent-01 bk-agent-01 commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Refs: Tushar's request in Claude Account Limits Display.

Summary

The Mobile Native Static Analysis job waits for blacksmith-6vcpu-macos-26 without an assigned runner. Tushar requested its removal.

Remove the job, its unused workflow output, and its references from the final Check job. Correct the Android instructions to describe native lint as a manual command.

The shared change detector still exposes mobile_native because the local changed-file command uses it. The vp run lint:mobile command remains available.

Keep Release Smoke. Pin @expo/fingerprint to 0.21.5 and expo-network to 58.0.3 under overrides. Update the matching lockfile metadata. Both packages already use these versions and patches in the committed lockfile.

This PR targets stage. Another session owns the production promotion. PR #343 remains unchanged because its approved promotion has an older scope.

How I tested

  • Reviewed every job dependency and searched for the removed job name and runner label. No references remain in .github, docs, or scripts.
  • Confirmed that the shared mobile_native output still has a consumer in scripts/check-changed.ts.
  • git diff --check passed.
  • CI verified head 33a38741fc9c5df3f9f0a4ddfef7173ae16fa31f: 23 checks passed and three were skipped. The newest run of each check determines this result.
  • CI run 39921372176 passed, including Release Smoke, all eight server test shards, the web and package tests, lint, build, typecheck, Rust, and the final Check.
  • The stage deployment validation, fork markers, and native fingerprint comparison also passed.
  • No local tests, lint, typecheck, or build ran under the shared-host policy.

Release Smoke repair

Release Smoke failed on 4a45c23b7d with ERR_PNPM_UNUSED_PATCH for @expo/fingerprint@0.21.5 and expo-network@58.0.3.

The same failure appears in the earlier stage-branch job. The first commit changed only the workflow and the Android instructions. Every other completed check on that head passed or was skipped. The final Check failed because Release Smoke failed.

The smoke fixture deletes its copied lockfile before it resolves dependencies. The version pins preserve both patches during that fresh resolution, as the existing override already does for expo-modules-core.

Tushar authorized this repair through his Manager. This approval grants no merge or deployment permission. Release Smoke and the final Check passed on the final head above.

The lockfile metadata includes both override entries and the effective expo-network importer specifier, 58.0.3. CI on 60e71816a9 exposed that the importer still used ~58.0.3; every dependency install stopped at that mismatch. The follow-up commit corrects the specifier. Package versions, patch hashes, and resolved dependency entries remain unchanged.

Risks and rollback

Native mobile static analysis no longer runs automatically in CI. Run vp run lint:mobile manually when required. Revert this commit to restore the job.

Model: GPT-6.1-sol. Harness: Codex in T3 Code.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 23, 2026
@bk-agent-01
bk-agent-01 marked this pull request as ready for review October 23, 2026 06:37
@bk-agent-01 bk-agent-01 changed the title ci: remove queued native mobile static analysis job ci: remove blocked mobile job and preserve patched Expo versions Oct 23, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 60e7181.

This comment will update automatically after the next completed run.

@bk-agent-01

Copy link
Copy Markdown
Collaborator Author

Tushar authorized "Merge to stage" in this session for head 33a38741fc9c5df3f9f0a4ddfef7173ae16fa31f.

The final check found 23 successful checks and three intended skips. Release Smoke, the final Check, and stage deployment validation passed. No review threads remain open. The branch contains the current stage base.

This merge targets stage and starts its deployment. Another session retains the production promotion.

@bk-agent-01
bk-agent-01 merged commit 235c600 into stage Oct 23, 2026
27 of 28 checks passed
@bk-agent-01

Copy link
Copy Markdown
Collaborator Author

Stage deployment verified for merge commit 235c60019476644bb78db9f4f6a1b623fcaf704f.

  • Deployment run 39925183661 passed and published the artifact for this merge SHA.
  • /home/ubuntu/.t3/stage-dev/deployed-sha and the stage checkout HEAD both match that SHA.
  • t3-stage.service is active since 2026-10-23 08:36:21 UTC, with zero automatic restarts.
  • The stage health endpoint returns HTTP 200. Its server version is 0.1.2-nightly.20261021.3499.upstream.g05b697f6a201.
  • The startup log check found zero ERROR lines and zero event-loop stalls. The ten-minute baseline also had zero of each.
  • The deployed CI workflow has no Mobile Native Static Analysis job or reference to its former runner label.

Production remains on 0c8bfb3cfad25c0cef5a577baba006395d9828bc. Another session owns the production promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant