Fix: panel version badge clipped off Overview hero title - #1
Open
ShiyunXu wants to merge 1 commit into
Open
Conversation
The hero h1 combined whitespace-nowrap with an ancestor overflow-hidden container, so on narrower viewports or longer translated titles the appended version text was silently clipped and never visible, even though the backend GET /api/version route is public and the frontend useVersion/PANEL_VERSION code fetches and renders it correctly. Removing whitespace-nowrap lets the title wrap instead of truncating the version suffix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard was not showing the installed panel version on the Overview page.
Root cause: the hero
<h1>inweb/src/pages/Overview.tsxcombinedwhitespace-nowrapwith an ancestoroverflow-hiddencontainer. On narrower viewports or with longer translated titles, this silently clipped the appendedv{panelVersion}text so it never appeared, even though:GET /api/versionis already public (no auth) ininternal/panel/api/server.go.useVersion()hook (web/src/api/hooks.ts) andPANEL_VERSIONfallback wired intoOverview.tsx/AppSidebar.tsx.Fix: removed
whitespace-nowrapfrom the<h1>className so the title wraps instead of truncating the version suffix.Verified with
tsc --noEmitandvite buildon this branch.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com