fix(ai-agent): forward model-authored tool description from BackendOutputSink - #945
Open
kylexu88 wants to merge 1 commit into
Open
fix(ai-agent): forward model-authored tool description from BackendOutputSink#945kylexu88 wants to merge 1 commit into
kylexu88 wants to merge 1 commit into
Conversation
…tputSink The BackendOutputSink hardcoded `description: None` when forwarding aionrs tool calls, so a model-authored description never reached the frontend and the step label always fell back to the raw command. Extract the optional `description` field from the tool input instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackendOutputSinkhardcodeddescription: Nonewhen forwarding aionrstool-call events to the frontend. A model-authored
descriptionthereforenever reached the renderer, and the tool-step label always fell back to the
raw command string.
Changes
descriptionfield from the parsed tool input inemit_tool_calland forward it throughToolCallEventDatainstead ofNone.paths.
Testing
emit_tool_call_extracts_description_from_inputemit_tool_call_without_description_keeps_nonejust push:cargo nextest run --workspace: 9131 passed, 50 skippedRelated
Companion to the AionUi tool-execution rendering refactor — the frontend
already renders
descriptionwhen present, so this wires the backend side ofthe same fix.