Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens linting by enabling Ruff’s flake8-builtins (A) rules across the repo while explicitly allowing builtin-shadowing for specific API-field-like parameter names, and fixes a single test case that previously shadowed a builtin.
Changes:
- Enable Ruff flake8-builtins rules (
A) and globally ignoreA002(intentionalid/typeparameter names). - Rename a shadowing local variable (
input→data) intests/test_obfuscate.py. - Restructure Ruff
ignoreconfiguration into a multiline list for clarity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_obfuscate.py | Renames input variable to avoid builtin shadowing under new Ruff rules. |
| pyproject.toml | Enables Ruff A rules and adds global ignore for A002 to accommodate API field naming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Globally ignore A002 since id/type are API field names - Rename shadowing local variable in test (input -> data)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id,typeintentionally match Overkiz API field names)inputvariable intest_obfuscate.pyTest plan
ruff check .passespytest— 280 tests pass