Enable ruff PYI rule (type annotation improvements)#2003
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Ruff’s flake8-pyi (PYI) lint rules and applies the resulting type-annotation cleanups across the codebase to improve typing clarity and consistency.
Changes:
- Enable Ruff
PYIrules inpyproject.toml. - Update
OverkizClient.__aenter__to returnSelf(PYI034). - Simplify
int | floattofloatin relevant type hints (PYI041).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adds PYI to Ruff’s selected lint rules. |
| pyoverkiz/models.py | Simplifies numeric type hints for ValuePrototype initializer parameters. |
| pyoverkiz/client.py | Uses Self as the return type for __aenter__ and imports it from typing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use Self return type for __aenter__ (PYI034) - Simplify int | float to float in ValuePrototype (PYI041)
Address review feedback: align ValuePrototype class attribute annotations with __init__ parameter types (int | float -> float).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selfreturn type for__aenter__(PYI034)int | floattofloatin type hints (PYI041)Test plan
ruff check .passespytest— 280 tests passmypypasses