Skip to content

Enable ruff ERA rule (remove commented-out code) #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMicknl merged 1 commit into from
Apr 19, 2026
+4 −7
Merged

Enable ruff ERA rule (remove commented-out code) #2002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyoverkiz/enums/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class GatewaySubType(UnknownEnumMixin, IntEnum):
TAHOMA_PRO = 14
TAHOMA_SECURITY_SHORT_CHANNEL = 15
TAHOMA_SECURITY_PRO = 16
# TAHOMA_BOX_C_IO = 12 # Note: This is likely 17, but tahomalink.com lists it as 12
TAHOMA_BOX_C_IO = 17

@property
def beautify_name(self) -> str:
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ select = [
"RET",
# flake8-pie
"PIE",
# eradicate
"ERA",
]
ignore = [
"E501", # Line too long
Expand Down
5 changes: 0 additions & 5 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,11 +469,6 @@ async def test_get_diagnostic_data_without_masking(self, client: OverkizClient):
exceptions.ResourceAccessDeniedError,
400,
),
# (
# "local/204-no-corresponding-execId.json",
# exceptions.OverkizError,
# 204,
# ),
(
"local/400-bad-parameters.json",
exceptions.OverkizError,
Expand Down
2 changes: 1 addition & 1 deletion utils/generate_enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from pyoverkiz.models import UIProfileDefinition, ValuePrototype

# Hardcoded protocols that may not be available on all servers
# Format: (name, prefix, id, label)
# Each tuple contains: name, prefix, id, label
ADDITIONAL_PROTOCOLS: list[tuple[str, str, int | None, str | None]] = [
("HLRR_WIFI", "hlrrwifi", None, None),
("MODBUSLINK", "modbuslink", 44, "ModbusLink"), # via Atlantic Cozytouch
Expand Down
Loading