Enable additional ruff lint rules (zero-violation batch)#1998
Merged
Enable additional ruff lint rules (zero-violation batch)#1998
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables additional Ruff lint rule families that are currently violation-free, with targeted exceptions/ignores where the project intentionally deviates.
Changes:
- Expanded Ruff
selectto include 15 additional rule sets and added global ignore forTRY003. - Added per-file ignores for tests (
SLF001) and utils (INP001,BLE001). - Added an inline
# noqa: BLE001for an intentional broadexcept Exceptionin the action queue batch executor.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyproject.toml |
Enables additional Ruff rule families and configures global/per-file ignores to keep checks passing without code churn. |
pyoverkiz/action_queue.py |
Adds a targeted noqa for an intentional broad exception catch to satisfy newly enabled BLE rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add five new rule sets that pass cleanly without any code changes: pycodestyle warnings, flake8-logging, flake8-datetimez, flynt, and flake8-implicit-str-concat.
Add PGH, SLF, SLOT, TID, INP, ICN, G, BLE, TRY, and Q rule sets. Ignore TRY003 globally (long exception messages are idiomatic here). Add per-file ignores for tests (SLF001) and utils (INP001, BLE001). Add noqa for intentional blind except in ActionQueue worker.
iMicknl
force-pushed
the
v2/ruff_additional_checks
branch
from
e10a681 to
7ee839f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
ruff check .passespytest— 280 tests passmypypasses