Correct Preset 3 and 4 commands and add substitutions#115
Correct Preset 3 and 4 commands and add substitutions#115frenetic00 wants to merge 1 commit intoiMicknl:mainfrom
Conversation
|
Which control panel are you using? |
| preset_3_name: "Preset 3" | ||
| preset_3_icon: "mdi:numeric-3-box" | ||
| preset_4_name: "Preset 4" | ||
| preset_4_icon: "mdi:numeric-4-box" |
There was a problem hiding this comment.
I'd personally prefer to keep these as sit/stand, because I think that's more common. If users want to change it to 3/4 then I think it's easier to infer those changes than to make the right changes for sit/stand.
There was a problem hiding this comment.
I'm using the HCB213A-1
I added them as substitutions to give users more flexibility which preset is associated with sit / stand as it might not always default to 3 and 4. The link for the different Loctek control panels seems to be dead but from the images I've seen, some panels only have presets 1-3.
I could add a commit so that preset 3 and 4 default to sit and stand respectively?
The substitutions result in a smaller config with more flexibility and less editing overall:
packages:
remote_package: github://frenetic00/LoctekMotion_IoT/packages/office-desk-esp32.yaml
substitutions:
device_name: Flexispot - Office Desk
max_height: '100'
min_height: '71'
name: flexispot-office-desk
preset_1_icon: mdi:chair-rolling
preset_1_name: Sit
preset_2_icon: mdi:human-handsup
preset_2_name: Stand
There was a problem hiding this comment.
Would be great if you can make this change!
|
Thanks for your contribution, @frenetic00, and apologies for the very late reply. The button mapping depends on the control panel and is fairly easy to adjust in code. Your changes around the substitutions make sense, but I think it would be good to keep the original mapping as the default. Would you mind double-checking that there are no breaking changes? Happy to merge once you have changed the name back to "Sit" and "Stand". |
Preset 3 button currently issues the command for Preset 4 and vice versa.
Added substitutions so that Sit / Stand can be configured to different presets numbers other than 3 and 4.