Repository navigation
window: don't wrap a null swapchain buffer - #155
Merged
Merged
Conversation
resizeSwapchain wrapped swapchain->next() in a CWaylandBuffer without checking it. next() is null when the swapchain can't allocate (a software renderer with no dmabuf), and the ctor dereferences it, so the app segfaults on first configure. Leave the slot empty instead; render() and onPreRender already bail when a buffer is missing.
vaxerski
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resizeSwapchainwrapsswapchain->next(nullptr)in aCWaylandBufferwithout checking it.next()is null when the swapchain can't allocate (a software renderer with no dmabuf), and the ctor dereferences it, so the app segfaults on the first configure instead of failing cleanly. Leave the slot empty instead;render()andonPreRenderboth already bail when a buffer is missing.@erickbatistaprado diagnosed this in #144 (QEMU virtio, no virgl, kms_swrast) and pointed at the exact fix. I couldn't repro the alloc failure on real hardware here (the gpu allocates), so this is compile-tested plus the normal path is unchanged by construction (the new branch only runs when next() is null). A confirm from the software-renderer setup would be good.
Fixes #144.