Repository navigation
Conversation
…s on wake Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing style Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If fprintd goes away while a verification is running and the system then suspends, fingerprint auth never comes back after wake. It stays dead for the rest of that lock session, and only a password unlock recovers it.
The
PrepareForSleep(false)handler only callsstartVerify()whenverifyingis false.verifyingis cleared only bystopVerify(), which runs in response to aVerifyStatussignal. When fprintd exits during a verify (stopped before suspend, restarted, or killed with the sensor), noVerifyStatusis sent.verifyingstaystrue, the wake handler does nothing, and hyprlock keeps a device proxy whose claim belongs to a dead fprintd instance. On unlock,terminate()then fails with:I hit this on a ThinkPad X1 Extreme Gen 5 (Synaptics
06cb:00f9, the sensor from #577). It loses power in S3, so fprintd is stopped before suspend; otherwise the open claim wedges the daemon across resume. A lock started at suspend time works, because no verify is running yet. A suspend that interrupts a running verify (lock, brief wake, suspend again) hits the bug every time.Fix
On
PrepareForSleep(true), stop the verify and release the device right away. That clearsverifyingand resets the proxy, so the wake path always goes throughcreateDeviceProxy()→Claim→VerifyStartagainst whatever fprintd instance is alive after resume. Both calls already handle D-Bus errors, so this is harmless if fprintd has already gone.Testing
mainwith this change builds cleanly;clang-format --dry-run -Werrorpasses.🤖 Generated with Claude Code