Repository navigation
core: defer auth initialization until session lock is acquired - #1091
Merged
Merged
Conversation
Starting CAuth and spawning the PAM/fingerprint auth threads before acquiring the session lock causes secondary hyprlock instances (or instances launched while another lockscreen is active) to hang on exit joining PAM threads or holding resources. By deferring g_pAuth->start() until acquireSessionLock() succeeds, a rejected instance exits immediately without stranding background threads or pinning GPU/system memory. Also send destroy on lock object when finished is received before locked per ext-session-lock-v1 spec. Fixes hyprwm#1075
vaxerski
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting
CAuthand initializing PAM / fingerprint threads beforeacquireSessionLock()causes secondary instances (or any instance launched while another lockscreen holds the session lock) to hang during exit when joining the PAM authentication thread, while pinning Wayland connections and preloaded texture/screencopy memory in RAM.Changes
g_pAuth = makeUnique<CAuth>(); g_pAuth->start();until afteracquireSessionLock()succeeds.g_pAuth->terminate()withif (g_pAuth).onLockFinished(), when!m_sLockState.locked, explicitly callm_sLockState.lock->sendDestroy()per theext-session-lock-v1specification.Fixes #1075