Add worker support for inline PDF attachment detection and downloading - #10
Add worker support for inline PDF attachment detection and downloading#10jaybaird wants to merge 1 commit into
Conversation
…sent from Apple Mail
|
Thank you for this — the bug you found is fixed as of v1.10.1, and your report is what drove it. I'm closing this pull request because the fix that shipped works differently, and it's worth explaining why rather than leaving it to guesswork. Your diagnosis was right, and the extraction half turned out to be already fixed. I ran the test from this branch verbatim against The real gap was that nothing ever asked. The paperclip is decided before any body is fetched, and attachments are only downloaded for messages that decision flagged — so a message it missed could never correct itself: no flag, no fetch, no attachments, indefinitely. That's what made the file invisible even though the parser could see it. On the What shipped instead is evidence rather than a better guess. Both MIME shapes — yours and the reporter's — are now regression tests, and #9 is closed. Thanks for taking the time to dig into |
|
Fixed a different way in v1.10.1 (see above) — closing. Thanks again for the report and the patch. |
Potential fix for #9. I recevied an email from someone using Apple Mail that attached an inline PDF. Vireo did not display or detect that there was an attachment in the message. This checks the message for an inline base64 attachment and triggers the attachment download and attachment viewer for these messages.
Displaying inline I think is a non-starter due to https://bugs.webkit.org/show_bug.cgi?id=164423.