[FIX] Refactor player rank checks to use player object to fix condition ranks. - #228
Open
john-clardy wants to merge 1 commit into
Open
[FIX] Refactor player rank checks to use player object to fix condition ranks.#228john-clardy wants to merge 1 commit into
john-clardy wants to merge 1 commit into
Conversation
hypherionmc
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for querying conditional/active FTB Ranks for online players while preserving the existing behavior for profile-based lookups.
Previously, CraterGameProfile lookups used RankManager.getAddedRanks(...), which only returns explicitly assigned ranks. This made it impossible for integrations to detect ranks granted through FTB Ranks conditions.
Changes
Updated FTB Ranks role synchronization to use getPlayerRanks(CraterPlayer) instead of the profile-based lookup. CraterLib Pull required to enable this.
Updated active rank checks during synchronization to use hasRank(CraterPlayer, String).