Skip to content

fix(ci): the invisible-character gate never matched anything #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 5 commits into from
Sep 12, 2026
Merged

fix(ci): the invisible-character gate never matched anything #25

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72f273e
fix(ci): the invisible-character gate never matched anything
hyperpolymath Aug 27, 2026
ef3b618
fix(ci): make invisible-character PCRE locale-independent
hyperpolymath Aug 28, 2026
777e734
Merge branch 'main' into fix/empty-linter-pattern-never-matched
hyperpolymath Aug 30, 2026
00b4f76
Merge branch 'main' into fix/empty-linter-pattern-never-matched
hyperpolymath Sep 4, 2026
9491035
Merge branch 'main' into fix/empty-linter-pattern-never-matched
hyperpolymath Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dogfood-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
# Checks for: zero-width spaces, zero-width joiners, BOM, soft hyphens,
# non-breaking spaces, null bytes, and other invisible Unicode in source files.
set +e
PATTERNS='\xc2\xa0|\xe2\x80\x8b|\xe2\x80\x8c|\xe2\x80\x8d|\xef\xbb\xbf|\xc2\xad|\xe2\x80\x8e|\xe2\x80\x8f|\xe2\x80\xaa|\xe2\x80\xab|\xe2\x80\xac|\xe2\x80\xad|\xe2\x80\xae|\x00'
PATTERNS='(*UTF)[\x00-\x08\x0B\x0C\x0E-\x1F\x{a0}\x{ad}\x{200b}-\x{200f}\x{202a}-\x{202f}\x{2060}\x{2066}-\x{2069}\x{feff}]'
find "$GITHUB_WORKSPACE" \
-not -path '*/.git/*' -not -path '*/node_modules/*' \
-not -path '*/.deno/*' -not -path '*/target/*' \
Expand All @@ -137,7 +137,7 @@ jobs:
-o -name '*.yml' -o -name '*.yaml' -o -name '*.md' -o -name '*.adoc' \
-o -name '*.idr' -o -name '*.zig' -o -name '*.v' -o -name '*.jl' \
-o -name '*.gleam' -o -name '*.hs' -o -name '*.ml' -o -name '*.sh' \) \
-exec grep -Prl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null
-exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null

@codacy-production codacy-production Bot Aug 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Suggestion: Using + instead of \; allows find to pass multiple file paths to a single grep process, which is significantly faster. Additionally, the -r (recursive) flag is redundant because find is already traversing the directory structure.

EL_EXIT=$?

@codacy-production codacy-production Bot Aug 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The exit code captured here reflects the status of the find command, not the success or failure of the grep scans. Since find ignores the exit status of -exec ... \; unless it refers to a filesystem error, EL_EXIT will likely always be 0. To accurately signal a failure, you should derive the status from the count of findings or use find ... -exec ... + which returns non-zero if any invocation fails.

set -e

Expand Down
Loading