Repository navigation
ci: give dtolnay/rust-toolchain a valid toolchain input - #136
Conversation
dtolnay/rust-toolchain at @v1 (and at its master-branch commits) declares `toolchain` as required with no default; only the toolchain-named branches such as @stable supply one. Steps here either: - set no `toolchain:` at all, so the action fails with "'toolchain' is a required input"; - set an invalid value (v1, master, or a note), which rustup cannot install; or - carry a second `with:` key injected above the real one by an earlier bulk edit. A duplicate key makes GitHub reject the whole workflow file. Each affected step now has exactly one `with:` with a valid toolchain: an injected toolchain-only `with:` block is dropped, an invalid value becomes `stable`, and a step with none gets `toolchain: stable`. An existing valid value ('1.97.0', ${{ env.RUST_VERSION }}, stable) is kept as is. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check |  |
The description clearly explains the invalid duplicate toolchain input and the removal of the affected blocks in all three workflow files. |
| Title check | |
The title is concise, specific, and accurately describes the CI workflow correction. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
CI annotation context is incomplete: annotation collection unavailable or limited
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Add Carrot credits or activate Agent usage billing to use Autofix |
2 participants
What was wrong
finishingbot.yml,rhodibot.ymlandseambot.ymleach carried an injectedwith: toolchain: v1above the realwith: toolchain: stable. The duplicate key makes GitHub reject the whole workflow file, andv1isn't a toolchain.Changes
Drop the injected block in all three; the real
toolchain: stablestays.Testing
YAML parses; standards'
check-lock-sync.shreports no new failures.Generated by Claude Code