Repository navigation
fix(lock): keep relock-standards-pin's original pin match, minus comment lines - #1319
Conversation
…ent lines Root-cause fix for two Codex findings on #1317. Each narrowing of the pin scan (`^\s*uses:`, then `uses:` after `{`, `,` or space) dropped a YAML form main's unanchored scan found: first one-line flow calls, then quoted keys (`"uses": …@<sha>`). The only line that needed excluding was a full-line comment, so standards_pins is now main's match with those lines removed, and nothing else changed. New test case for a quoted key; each earlier version fails the case it missed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N6my4F3ohjwFReLW8cYYqC
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
🟢 conformant · commit
K9 live corpus (L0–L2): 2 finding(s) / scope notes
Scope: DEED syntax and K9 contracts L0–L2. L3 signature verification and routed coordination dialects are not certified. Green is limited to this scope. Orange is missing evidence; grey is an explicit scope exclusion. Logs and report.json are in the dated conformance-evidence artifact on the linked run. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |



Summary
This follows up #1317, which merged at
b3862040before this fix was pushed. It answers Codex's second finding on #1317 (quoteduseskeys).#1317 changed
standards_pinsso that commented caller examples no longer count as pins. Each version it shipped matched pins more narrowly than main's original scan, and each one dropped a YAML form the original found:^\s*uses:dropped one-line flow calls,build: { uses: "…@<sha>" };uses:after{,,or a space (what merged) drops quoted keys,"uses": …@<sha>.apply-workflow-pins-remote.shstill rewrites the SHA in such a call, but the relock then refuses with "no workflow pins".The only line that needed excluding was a full-line comment.
standards_pinsis now main's original match with those lines removed, and nothing else changed:Type of change
How has this been verified?
bash scripts/tests/relock-standards-pin-test.sh→PASS, with one new case: "a quoted uses key is counted as a pin". I ran the suite against the script at each earlier version. Each fails exactly the case it missed:38e4d91ab3862040(merged)useskeyOn this repo,
relock-standards-pin.sh --to d55304a0reports "already keyed" andcheck-lock-sync.shreports in sync.shellcheck -S warningon the script is clean.Checklist
Notes for reviewers
A
run:body or a trailing comment that quotes a pin still counts, as it always has. Excluding those would need a YAML parser. This script greps everywhere else, so I kept it to the one exclusion that was actually breaking relocks.Separately, #1317 works on main: Mirror run 1169 on
0d47b892started under its real name and resolvedmirror-reusable.yml@d55304a0.Generated by Claude Code