Repository navigation
chore(ci): remove the unused signed-push action and its smoke test - #1312
Conversation
signed-push re-pushed a workflow's commits as GitHub-Verified through a GitHub App. That App was never created: vars.APP_ID and secrets.APP_PRIVATE_KEY have never been set on this repo. Nothing else used the action either. The 2026-10-14 workflow audit (docs/reorg/2026-10-14-tidy/workflow-audit.adoc) counts 0 external consumers, and here only its own smoke test called it. That smoke test has failed on every run since 2026-08-24. A manual run today (run 39333160936) failed for the same reason: an empty app-id. The owner asked for it to be removed, since it is not attached to anything in use. Removed: - .github/actions/signed-push/ (action.yml, push-verified.sh, README.md) - .github/workflows/signed-push-smoke.yml - scripts/tests/signed-push-test.sh - the smoke workflow's actions.lock entry, dropped by prune-stale.sh References updated: - SIGNING-POLICY.adoc: the bot-commit row and the "git push from a workflow" path now name createCommitOnBranch directly, which is what the action wrapped. scripts/regen-dependabot-locks.sh is the example. The rule itself is unchanged. - config/README.adoc, tag-ruleset-canon.yml, dependabot-lock-regen.yml: signed-push is gone from the lists of APP_ID readers. Left as they are: - historical notes in .githooks and docs/reorg. - the local-action placeholder string in validate-sha-pins-test.sh, which never needed the real directory. Checks: - check-lock-sync, validate-actions-lock, validate-sha-pins and the actions-lock gate (gh-actions-lock v0.2.0) pass. - prune-stale makes no further change. check-workflow-duplicate-keys, check-standards-map and link-rot-guard pass. actionlint is clean. - Shell suite: 86/89. The 3 failures fail the same way on origin/main for missing local tools (deno, ssh-keygen, the pinned gh-actions-lock binary). gh-actions-lock-contract-test passes 19/19 when that binary is supplied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014h2gFLLQibfB5N5hFz9ZCD
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🟢 conformant · commit
K9 live corpus (L0–L2): 2 finding(s) / scope notes
Scope: DEED syntax and K9 contracts L0–L2. L3 signature verification and routed coordination dialects are not certified. Green is limited to this scope. Orange is missing evidence; grey is an explicit scope exclusion. Logs and report.json are in the dated conformance-evidence artifact on the linked run. |
|
|
The gate keeps exactly two findings: #1300 moved No fix exists yet. Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |



Summary
signed-pushre-pushed a workflow's commits as GitHub "Verified" through a GitHub App. That App was never created:vars.APP_IDandsecrets.APP_PRIVATE_KEYhave never been set on this repo, so the action has never worked here. It also has no users:docs/reorg/2026-10-14-tidy/workflow-audit.adoc) counts 0 external consumers.That smoke test has failed on every run since 2026-08-24. A manual run today, run 39333160936, failed for the same reason: an empty
app-id. The owner asked for it to be removed, since it isn't attached to anything in use.Removed
.github/actions/signed-push/(action.yml,push-verified.sh,README.md).github/workflows/signed-push-smoke.ymlscripts/tests/signed-push-test.shactions.lockentry, removed withscripts/prune-stale.shrather than by handReferences updated
docs/SIGNING-POLICY.adoc: the bot-commit row and the "git pushfrom a workflow" path now namecreateCommitOnBranchdirectly, which is what the action wrapped.scripts/regen-dependabot-locks.shis given as the example. The policy itself is unchanged.config/README.adoc,tag-ruleset-canon.ymlanddependabot-lock-regen.yml(comment only): the smoke test is gone from the lists ofAPP_IDreaders.Left as they are
.githooks/comments anddocs/reorg/records../.github/actions/signed-pushstring invalidate-sha-pins-test.sh. It is only a placeholder name for a local action in a temporary folder and never needed the real directory.Testing
Lock checks:
check-lock-sync,validate-actions-lockandvalidate-sha-pinspass. The actions-lock gate passes with gh-actions-lock v0.2.0, the version CI pins.prune-stalemakes no further change, andlock-selfcheck HEADreports the commit self-consistent.Other checks:
check-workflow-duplicate-keys,check-standards-mapandlink-rot-guardpass on the edited docs.actionlintis clean on the two edited workflows. The pre-commit and commit-msg hooks pass.Shell suite: 86 of 89 test files pass. The other 3 fail the same way on
origin/mainbecause tools are missing locally:js-runtimes-testdenoscience-ci-security-testssh-keygengh-actions-lock-contract-testclose-lock.sh: when run offline, it reports one ref it cannot read (hyperpolymath/standards@427eb35c). A cleanorigin/mainreports exactly the same.Note
The smoke run today left the branch
ci/signed-push-smoke-39333160936behind, because the workflow's cleanup step only runs after a successful push. That branch points atmain's head and has no commits of its own. This session cannot delete branches (HTTP 403), so it needs deleting from the Branches page.Generated by Claude Code