Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #133

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8c3904eb-4e74-4878-a9d2-cda6137ed010

📥 Commits

Reviewing files that changed from the base of the PR and between 90eba40 and c0136ee.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (19)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: analyze (javascript-typescript, none)
🔇 Additional comments (2)
.github/workflows/governance.yml (1)

21-24: LGTM!

.github/workflows/mirror.yml (1)

20-23: LGTM!


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Corrected workflow permission configuration for governance and mirroring automation.
    • Ensured the existing read and security-event permissions are applied at the correct job level.
  • Chores
    • Preserved existing workflow triggers, reusable workflow references, and permission values.

Walkthrough

The pull request corrects the indentation and placement of job-level permissions blocks in two GitHub Actions workflows. Permission keys and values remain unchanged.

Changes

Workflow permission alignment

Layer / File(s) Summary
Job-level permission alignment
.github/workflows/governance.yml, .github/workflows/mirror.yml
The permissions blocks now sit directly under their jobs, alongside uses. The existing permission values remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: repairing invalid YAML caused by incorrect permissions block indentation in CI workflows.
Description check ✅ Passed The description accurately explains the invalid YAML issue, the indentation correction, and preservation of the existing permission grants.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow lines
Permissions sit in proper signs
uses and access now align
The same safe values remain in line
Two jobs hop through YAML fine

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit e452a40 into main Sep 21, 2026
20 of 22 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant