Repository navigation
deed: attest egress for the three secret-bearing workflows (standards ADR-009) - #259
Conversation
… ADR-009) Adds the (egress …) clause to rsr-template-repo_chora.deed, through scripts/deed-clause.sh append, for push-email-notify (notify), sonarqube (sonarqube) and build-notification (trigger-boj). Each entry lists exactly the secrets the job reads, the endpoints outside GitHub it reaches, and :enforcement none. No workflow changes; harden-runner is not adopted. Hypatia RE001 (with hyperpolymath/hypatia's matching change) accepts these entries in place of step-security/harden-runner. On this tree it reports 3 RE001 findings at main and 0 with this clause. Every repo minted from the template inherits the entries; existing repos need them added to their own deed (the sweep owed in ADR-009). Checks: deed_lint OK; deed_egress OK (3 egress jobs); check-no-a2ml and check-no-placeholders pass. check-root-shape fails identically at main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDithtn5Xk5MbSPm4Px
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Updated after #260 and #258 merged. This branch now includes both. The root-shape, estate-audit and OpenSSF failures are fixed on One failure remains, and it doesn't come from this PR. The Hypatia Security Scan and the Static Analysis Gate report 1 critical finding: The fix already exists: hyperpolymath/hypatia#963, followed by a This PR changes only Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e747e6cefd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review (P1): the sonarqube job's egress entry listed only the SonarCloud hosts. Verified in SonarSource/sonarqube-scan-action at v8.3.0: action.yml defaults scannerBinariesUrl to binaries.sonarsource.com, and src/main/gpg-verification.js (signature verification is on by default) imports the signing key from keyserver.ubuntu.com, falling back to keys.openpgp.org. All three join :endpoints, and :reason says why. The SMTP action fetches only its own release asset from github.com, which the profile treats as the implicit GitHub platform, so its entry stays. deed_lint and the egress profile pass; RE001 on this tree: 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDithtn5Xk5MbSPm4Px
|
Add Carrot credits or activate Agent usage billing to use Autofix |
|
Summary
This adds the
(egress …)clause torsr-template-repo_chora.deed, as decided in metadatastician/standards#1352 (ADR-009). It means the template's secret-bearing jobs satisfy Hypatia RE001 (hyperpolymath/hypatia#964) withoutstep-security/harden-runner. No workflow changes.Changes
(egress …)clause, added throughscripts/deed-clause.sh append, with one entry per job:push-email-notify.yml/notify: the four SMTP secrets, endpointsecret:SMTP_HOST.sonarqube.yml/sonarqube:SONAR_TOKEN, endpointssonarcloud.ioand*.sonarcloud.io.build-notification.yml/trigger-boj:BOJ_SERVER_URL, endpointssecret:BOJ_SERVER_URLandvar:BOJ_SERVER_URL. The workflow's documented secret fallback is kept and attested, not removed.:enforcement none, which is a true answer: the boundary is recorded, and nothing enforces it at run time yet.RSR Quality Checklist
Required
deed_lint.jsOK;deed_egress.jsOK (3 egress jobs)check-no-a2mlandcheck-no-placeholderspass.check-root-shapefails identically on main (pre-existing).unsafeblocks without// SAFETY:comments (n/a).envfiles included. Secret names only.As Applicable
(egress …)clause(ecosystem)/(meta): unchangeddocs/status/ROADMAP.adoc: unchangedTesting
With the hypatia change, RE001 run on this tree gives 3 findings on main and 0 on this branch.
Repos minted from the template inherit the entries. Existing repos are not affected by a workflow re-sync: each needs the entries added to its own deed. That sweep is listed as owed in ADR-009, and RE001's fix text gives the exact entry.
Screenshots
n/a
Generated by Claude Code