Repository navigation
fix(just): crg-grade and crg-badge never ran ($$ is Make, not just) - #235
Conversation
Both recipes used Make's `$$` escape. just has no such escape, so sh
received `grade=<pid>(grep ...)` and failed with `Syntax error: "("
unexpected` before reading READINESS.md. The seven `$$` in each recipe
are now `$`, in the root Justfile and in its byte-identical copy at
.machine_readable/contractiles/Justfile (still identical).
Checked with just 1.21 on the recipes extracted from the Justfile:
the old recipes fail with the syntax error; the new ones print X and the
grey X badge without READINESS.md, and D and the orange D badge with a
`**Current Grade:** D` line.
The same fix landed in hyperpolymath/standards in #1235; the CRG spec
names this template's Justfile as the recipes' source.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GqfpQtLuMczxtgG1U9PkLW
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the fix to the crg-grade and crg-badge recipes and explains the $$ syntax issue. |
| Description check | |
The description includes the required Summary, Changes, checklist, and Testing sections. It explains the failure, identifies both modified files, records validation results, and addresses the checklis… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
2 participants
Summary
just crg-gradeandjust crg-badgehave never worked. Both recipes use Make's$$escape, whichjustdoes not have. As a result,shreceivedgrade=<pid>(grep …)and stopped withSyntax error: "(" unexpectedbefore it ever readREADINESS.md.The CRG spec in
hyperpolymath/standardsnames this template's Justfile as the source of these recipes, so it is fixed here at the source. The same fix landed in hyperpolymath/standards#1235.Changes
Justfile: the seven$$incrg-gradeandcrg-badgebecome$..machine_readable/contractiles/Justfile: the same change. This file is a byte-identical copy of the rootJustfile, and the two stay identical after the fix.RSR Quality Checklist
Required
just testwas not run here, because this Justfile usesjustmodules, which the sandbox's just 1.21 cannot parse.unsafeblocks without// SAFETY:comments (none touched).envfiles includedAs Applicable
Nothing applies: no project state, integration, architecture or dependency changes.
Testing
Both recipes were extracted from the Justfile and run with just 1.21:
sh: 1: Syntax error: "(" unexpected.READINESS.md, they printXand the grey CRG X badge;**Current Grade:** Dline, they printDand the orange CRG D badge.🤖 Generated with Claude Code
https://claude.ai/code/session_01GqfpQtLuMczxtgG1U9PkLW
Generated by Claude Code
Summary by CodeRabbit
READINESS.md, withXused when no matching grade is found.