Repository navigation
ci: model Cabal package-index readiness - #100
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c34d816a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| {"case":"clean-runner","index":"missing","expected_plan":"refresh_then_resolve","source_run":"41404909112"} | |||
There was a problem hiding this comment.
Wire the Cabal readiness cases into an executable check
When a runner has a missing or unverified Cabal index, this addition does not prevent the resolver from running prematurely: a repository-wide search finds no script, test, or workflow that reads this fixture, so CI will remain green regardless of the plan selected. Add a runner/test that loads these cases, asserts expected_plan, and is invoked by the CI gate; otherwise the recorded failure from run 41404909112 is not actually covered.
Useful? React with 👍 / 👎.
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc8d82fdfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| {"case":"clean-runner","index":"missing","expected_plan":"refresh_then_resolve","source_run":"41404909112"} | |||
There was a problem hiding this comment.
Add REUSE metadata for the new fixture
On every checkout containing this fixture, the earlier REUSE compliance step in .github/workflows/ci.yml reports it as lacking copyright and licensing information and exits nonzero, because the file has no in-file SPDX declarations and REUSE.toml does not cover fixtures/ci/cabal-index.jsonl. Add a narrowly scoped REUSE annotation for this machine-readable fixture so the CI job can reach the new Cabal check.
Useful? React with 👍 / 👎.



First regression case from game-server-admin run 41404909112. Model and fixtures need integration with the runner before this is an enforcing gate.