Repository navigation
ci: give dtolnay/rust-toolchain a valid toolchain input - #133
Conversation
dtolnay/rust-toolchain at @v1 (and at its master-branch commits) declares `toolchain` as required with no default; only the toolchain-named branches such as @stable supply one. Steps here either: - set no `toolchain:` at all, so the action fails with "'toolchain' is a required input"; - set an invalid value (v1, master, or a note), which rustup cannot install; or - carry a second `with:` key injected above the real one by an earlier bulk edit. A duplicate key makes GitHub reject the whole workflow file. Each affected step now has exactly one `with:` with a valid toolchain: an injected toolchain-only `with:` block is dropped, an invalid value becomes `stable`, and a step with none gets `toolchain: stable`. An existing valid value ('1.97.0', ${{ env.RUST_VERSION }}, stable) is kept as is. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
|
✅ Coding Agent task started: View task and status The task will inspect the CI failures, validate its fix, and commit the fix to this branch automatically.
⏭️ Checks skipped: 1 · already failing on `main` (not caused by this PR)
|
…and sync Cargo.lock
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
What was wrong
dtolnay/rust-toolchain@v1declarestoolchainas required with no default. Heretoolchain: v1was set (not a toolchain rustup can install), and one step set none.Changes
bench.yml,release.yml,security.yml:toolchain: v1→stable(existingtargets:kept).security.yml: addtoolchain: stableto the clippy step that had none.Testing
YAML parses; standards'
check-lock-sync.shreports no new failures.Generated by Claude Code