Repository navigation
docs: correct the Rust test counts and the JS-suite claims - #154
Conversation
README, EXPLAINME-new and TEST-NEEDS gave 12 or 267 Rust tests. `cargo test --lib` runs 285 since #153, and before #153 only 23 of the 267 compiled. They also claimed a runnable JS suite ("97 JS", "CI enforces both"). 140 of the 143 files under tests/ import compiled ReScript output that #107 removed, #108 removed deno.json, and CI runs only the Rust gate. The docs now say the JS suite waits on the AffineScript port (#148). README's `bun task test` (there is no JS manifest) is now `cargo test --locked --lib`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
|
These checks are red, but this PR didn't cause it: every That pin comes from the The fix is #156, which repins to Generated by Claude Code |
GitHub's runner now enforces actions.lock inside reusable workflows, and for a reusable it reads the defining repository's lock. standards@092deda records actions/checkout@3d3c42e5 with `ref:` set to the SHA itself, which the runner rejects as "invalid lockfile pin". Hypatia (scheduled 18 Oct) and Scorecards (19 Oct) on main failed at job setup with exactly that; the 14 Oct push runs, on an older runner build, passed on the same commit. standards fixed its lock in f335165a (#1271). - Governance, Hypatia, Scorecards, Secret Scanner and Mirror move from standards@092deda to standards@75bd599 (main, 2026-10-19). Every input and secret the reusables gained since is optional. - secrets: inherit is narrowed to what each callee declares, as standards did for its own callers (#1283/#1284): HYPATIA_SCAN_PAT for Governance and Hypatia, the seven named forge keys for Mirror, nothing for Secret Scanner and Scorecards. - actions.lock: the standards@75bd599 record lists the external uses: of the five called files (the shape close-lock.sh writes, #1247), and each of those has a leaf record copied from standards' own lock at 75bd599 (tag refs, re-checked against git ls-remote). The record I added in #150 for actions/checkout@3d3c42e5 had the same SHA-as-ref defect; it is now ref v7.0.1. Rust CI stays on standards@412a703, which has no lockfile to enforce. Verified locally with standards' check-actions-lock-gate.sh and update-actions-lock.sh --verify-local at 75bd599, gh-actions-lock v0.2.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BCQeL169ZnUirUVaDXQLA3 (cherry picked from commit 689a79e)
standards@75bd599's secret scanner adds a full-history gitleaks pass. On this PR it found four historical findings, none a credential, none in the current tree: - docs/api-reference.md at aff0781: the placeholder snapshot id in the API examples (replaced in #140); - tests/aspect/security_test.mjs at 9eed9ac: synthetic ABCDEFGHIJ… OpenAI/GitHub-shaped fixtures for the redaction tests (built at runtime by syntheticToken() since #122). .gitleaksignore lists exactly those commit:file:rule:line fingerprints, the format standards uses for its own history. Reproduced with the pinned gitleaks 8.18.4 and the estate baseline: 4 leaks before, none after. Canary: the same placeholder committed again is still caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BCQeL169ZnUirUVaDXQLA3 (cherry picked from commit 926742f)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac5a2b1256
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Several lib tests set and remove the same process-wide environment variables (BOJ_URL in boj, governance and boj_live; also OVERLAY_URL, HYPATIA_URL and TYPELL_URL). In parallel they can see each other's values, which is why build-validation runs `cargo test --locked --lib -- --test-threads=1`. README and EXPLAINME-new now give that command instead of the parallel one. Found by Codex review on #154. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
…er-8qkxac-test-counts
|
|
Add Carrot credits or activate Agent usage billing to use Autofix |
2 participants
Summary
This PR changes docs only, in three files. It follows up on #153.
Rust test counts. README said 12, EXPLAINME-new said 12, and TEST-NEEDS said 267 "all passing".
cargo test --locked --libruns 285 since #153. Before #153, only 23 of TEST-NEEDS' 267 tests actually compiled. The rest lived in modules that no crate root declared. TEST-NEEDS keeps its 267 figure as history and adds a dated correction next to it.JS-suite claims. README ("97 JS") and EXPLAINME-new ("CI enforces both") described a JS suite that can't run today:
tests/import compiled ReScript output (src/**/*.res.js) that refactor: estate architectural upgrades #107 removed.deno.json.build-validation.ymlruns only the Rust test gate.The docs now say the JS suite waits on the AffineScript port (#148). TEST-NEEDS gets the same note under its JS rows. README's
bun task testbecamecargo test --locked --lib, because there is no JS manifest to define atesttask.Also: TEST-NEEDS said there are 116 Rust files; there are 112.
Not changed
README's other build commands (
bun task res:buildbures, "BuildBu", and so on) look damaged too. They belong to the frontend port, so this PR leaves them alone.Verification
cargo test --locked --libonmain(9961333): 285 passed.grep -c '#\[test\]\|#\[tokio::test\]'finds 288 matches. 285 are real tests. The other 3 are doc comments that mention#[tokio::test].Generated by Claude Code