Skip to content

ci(rust-ci): re-pin rust-ci-reusable past the toolchain-input breakage - #93

Merged
hyperpolymath merged 3 commits into
mainfrom
ci/rust-toolchain-input
Oct 19, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
ci/rust-toolchain-input

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

rust-ci.yml calls hyperpolymath/standards rust-ci-reusable at d135b05b. That version runs dtolnay/rust-toolchain by commit SHA without a toolchain: input, so every run fails with 'toolchain' is a required input before cargo starts.

Re-pin to standards@81dbf2dd, which passes toolchain: stable, uses the same actions/checkout@9c091bb2 as this repo's other reusables, and is already the pin of its governance and hypatia-scan callers.

Changes

  • rust-ci.yml: pin d135b05b → 81dbf2dd. Nothing else (actions.lock untouched).

Why not the newest standards commit: 95de3dfc uses actions/checkout@3d3c42e5, the commit this repo's lock records as checkout@v7.0.1. GitHub rejects that with invalid lockfile pin, failing the first job before any step. I tried it first, and also tried editing the lock; neither helped, so the final PR leaves the lock alone.

RSR Quality Checklist

Required

  • Tests pass (cargo test --locked --all-targets, stable)
  • Code is formatted (cargo fmt --check)
  • Linter is clean (cargo clippy --locked --all-targets -- -D warnings)
  • No banned language patterns
  • No secrets, credentials, or .env files included

Testing

On this PR: rust-ci / Detect Cargo.toml, Cargo check + clippy + fmt and Cargo test all pass. Other red checks (Hypatia, DEED, K9, workflow security linter) are red on main too and unrelated.

🤖 Generated with Claude Code

https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye

rust-ci.yml called hyperpolymath/standards rust-ci-reusable at d135b05b.
That version runs dtolnay/rust-toolchain by commit SHA without a
`toolchain:` input; a SHA ref carries no version, so every run fails in
the action's "parse toolchain version" step with "'toolchain' is a
required input". d135b05b is the only standards pin in the estate
without the fix (landed 2026-06-27).

Re-pin to standards@95de3dfc, whose reusable passes `toolchain: stable`,
and bring actions.lock's rust-ci.yml entry in line with it:

- the workflow entry names hyperpolymath/standards@95de3dfc instead of
  [] (check-lock-sync flagged the job-level ref as missing);
- add the hyperpolymath/standards@95de3dfc dependency record and the
  records for the four actions the reusable uses at that commit, copied
  verbatim from standards' own actions.lock at 95de3dfc.

No existing lock record is changed or removed. standards'
check-lock-sync.sh: rust-ci.yml leaves the failure list; nothing is
added to it.

Same fix as hyperpolymath/plasma-parser-writer#107, whose Rust CI is now
green on main with this pin.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
@hyperpolymath
hyperpolymath marked this pull request as ready for review October 19, 2026 17:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-19T17:19:58.885727Z 2b01586 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Job-level reusable calls here (mirror, governance, secret-scanner, ...) have
empty entries and no standards records, and they start fine. Adding a
non-empty hyperpolymath/standards@95de3dfc entry made GitHub validate the
call against the lock, and it rejected it for actions/checkout@3d3c42e5 with
'invalid lockfile pin'. Restore actions.lock to main so the PR only moves
the pin, like the other reusable calls.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
…her reusables use

95de3dfc's reusable uses actions/checkout@3d3c42e5, the commit this repo's
lock already pins as checkout@v7.0.1, and GitHub rejects it with 'invalid
lockfile pin' (the job fails before any step runs). Every other reusable
called here uses checkout@9c091bb2 and starts normally. 81dbf2dd has the
toolchain fix, uses that same checkout ref, and is already the pin of this
repo's governance and hypatia-scan callers.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f2ca443b-7920-40cd-afea-5f3a16ee23dd
📥 Commits

Reviewing files that changed from the base of the PR and between d019f2f and 2b01586.

📒 Files selected for processing: 1
  • .github/workflows/rust-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🔇 Additional comments: 1
.github/workflows/rust-ci.yml: 1

18-18: LGTM!

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the Rust CI workflow.

The rust-ci job now uses reusable workflow revision 81dbf2dd854b1444fd6236fa2352474383b2c2b9 instead of d135b05bfc647d0c0fbfedc7e80f37ea50f49236.

Changes: Rust CI workflow

Layer / File(s) Summary
Reusable workflow reference
.github/workflows/rust-ci.yml
The rust-ci job now references revision 81dbf2dd854b1444fd6236fa2352474383b2c2b9.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2b015

The updated Rust CI workflow pin provides the required toolchain setup, and no actionable merge-blocking risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 2b015

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/rust-ci.yml: The rust-ci job’s reusable workflow reference changed from revision d135b05bfc647d0c0fbfedc7e80f37ea50f49236 to 81dbf2dd854b1444fd6236fa2352474383b2c2b9.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the CI workflow change and the reason for re-pinning the reusable workflow.
Description check Passed The description includes the summary, changes, rationale, testing results, and relevant checklist items. It is complete enough to explain the change, although it does not explicitly address every opti…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the summary, changes, rationale, testing results, and relevant checklist items. It is complete enough to explain the change, although it does not explicitly address every optional checklist item.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

CI annotation context is incomplete: annotation collection unavailable or limited

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Add Carrot credits or activate Agent usage billing to use Autofix

@hyperpolymath
hyperpolymath merged commit 7f27c27 into main Oct 19, 2026
33 of 37 checks passed
@hyperpolymath
hyperpolymath deleted the ci/rust-toolchain-input branch October 19, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants