Skip to content

docs: add Signed commits section to CONTRIBUTING - #67

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e501cff1-391c-4e3f-a4d7-332954dc2411

📥 Commits

Reviewing files that changed from the base of the PR and between 529d41c and f2ed273.

📒 Files selected for processing (1)
  • .github/CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (25)
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: analyze (rust, none)
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Groove manifest check
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (3)
.github/CONTRIBUTING.md (3)

123-124: LGTM!

Also applies to: 127-137


138-138: 🎯 Functional Correctness

The effective merge settings for hyperpolymath/language-bridges cannot be determined. The GitHub API returned HTTP 404 before providing allow_rebase_merge or the applicable rulesets. The sentence and any settings correction therefore remain undecidable from the available evidence.


125-126: 🔒 Security & Privacy | 🛡️ Detected with Advanced Tier

Security Misconfiguration

CWE: CWE-693

Confirm that the signing ruleset applies to this repository.

The guidance states that every commit reaching the default branch must be signed. The effective required_signatures rule for hyperpolymath/language-bridges, including inherited rules and bypass actors, remains unavailable. Without that control, unsigned commits may reach the default branch. Apply the rule or correct the guidance.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance to require signed commits for changes reaching the default branch.
    • Clarified signing requirements for people, agents, apps, bots and workflows, and provided guidance for branches containing unsigned commits.
    • Documented squash merges as the required merge approach; rebase merges are disabled.

Walkthrough

The contribution guide now requires signed commits for changes reaching the default branch. It explains signing methods, how to handle unsigned PR commits, and the requirement to use squash merges.

Changes

Signed-Commit Guidance

Layer / File(s) Summary
Signing and merge requirements
.github/CONTRIBUTING.md
The guide describes signing requirements and methods, directs contributors to recreate branches with unsigned commits using signed cherry-picks, and states that squash merges are required while rebase merges are disabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f2ed2

This documentation-only change adds signed-commit guidance and carries no runtime risk. The statement that rebase-merge is disabled could be confirmed against the repository settings, but it does not block merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and key documentation changes, but it does not follow the required template. It omits the required Changes, RSR Quality Checklist, Testing, and Screenshots section… Update the description to use the required headings. Add the Changes section, complete every applicable RSR Quality Checklist item, describe testing or state why it is not applicable, and state whether screenshots are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a Signed commits section to CONTRIBUTING.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose and key documentation changes, but it does not follow the required template. It omits the required Changes, RSR Quality Checklist, Testing, and Screenshots sections.

  • Fix all pre-merge checks with AI
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit signs each commit with care
Then checks the branch before the merge
Unsigned changes get signed anew
A squash brings every change in view
The guide now shows the way to go

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@hyperpolymath
hyperpolymath merged commit 28cb47b into main Oct 1, 2026
32 of 33 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant