Repository navigation
ci: give dtolnay/rust-toolchain a valid toolchain input - #119
Merged
Merged
Conversation
dtolnay/rust-toolchain at @v1 (and at its master-branch commits) declares `toolchain` as required with no default; only the toolchain-named branches such as @stable supply one. Steps here either: - set no `toolchain:` at all, so the action fails with "'toolchain' is a required input"; - set an invalid value (v1, master, or a note), which rustup cannot install; or - carry a second `with:` key injected above the real one by an earlier bulk edit. A duplicate key makes GitHub reject the whole workflow file. Each affected step now has exactly one `with:` with a valid toolchain: an injected toolchain-only `with:` block is dropped, an invalid value becomes `stable`, and a step with none gets `toolchain: stable`. An existing valid value ('1.97.0', ${{ env.RUST_VERSION }}, stable) is kept as is. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
dtolnay/rust-toolchain@v1declarestoolchainas required with no default (only branches like@stablesupply one). Affected steps either set none ('toolchain' is a required input), set an invalid value (v1), or carry a secondwith:key injected above the real one by an earlier bulk edit. A duplicate key makes GitHub reject the whole workflow file.Changes
Each affected step now has exactly one
with:and a valid toolchain. Valid existing values are kept.rust-ci.yml: drop the injected duplicatewith:/toolchain: v1; addtoolchain: stableto the test job's step.coverage.yml:toolchain: v1→stable.Not fixed here
coverage.ymlis also blocked by an olderactions.lockmismatch (an action bumped without regenerating the lock). GitHub won't start it until the lock is regenerated; that is separate and unchanged.Testing
cargo check,fmt,clippy -D warningsandtestpass locally on stable. YAML parses; standards'check-lock-sync.shreports no new failures.Generated by Claude Code