Skip to content

fix(abi): review follow-ups from the JNK-01 stack (CodeRabbit on #149, Hypatia on #150) #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Oct 14, 2026
Merged

fix(abi): review follow-ups from the JNK-01 stack (CodeRabbit on #149, Hypatia on #150) #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99d53fe
fix(abi): CodeRabbit follow-ups from #149; agda-proofs is no longer D…
claude Oct 13, 2026
96f7804
ci(proofs): give the Agda job a timeout (Hypatia WH006 on #150)
claude Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/agda-proofs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: MPL-2.0
# SPDX-FileCopyrightText: 2026 Jonathan D.A. Jewell
name: Agda proofs
# DESIGNED until its first green run. Pattern: choreographic-types /
# First green run 2026-10-13, Agda 2.6.4.3 (PR #150). Pattern: choreographic-types /
# residual-evidence-types (pinned Debian prover, sibling fetched by commit).
# Checks verification/proofs/agda/Reversibility.agda under the kernel flags
# and refuses the fixtures under tests/reject-agda. Local run: just test-agda.
Expand All @@ -15,6 +15,7 @@ jobs:
proofs:
name: Reversibility as a grade (Loss instance), expected rejections
runs-on: ubuntu-latest
timeout-minutes: 15
# trixie-slim, resolved 2026-10-13; re-pin deliberately, like the prover below.
container: debian:trixie-slim@sha256:a29215f6a35e51e22adffa17f89e9d2ef06214e64a2bad10d765c46aea49f11f
steps:
Expand Down
2 changes: 1 addition & 1 deletion ffi/zig/include/januskey.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
/* SPDX-License-Identifier: MPL-2.0 */
/* Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) */
/* JanusKey C FFI Header — hand-maintained; src/abi/JanusKey/ABI/Foreign.idr must mirror it (checked by the ABI package typecheck) */
/* JanusKey C FFI Header — hand-maintained; src/abi/JanusKey/ABI/Foreign.idr mirrors it: symbols, status codes, enums and sizes are compared by scripts/check-abi-layout.sh */

#ifndef JANUSKEY_H
#define JANUSKEY_H
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-abi-tree.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fail=0
say() { echo "[check-abi-tree] $*"; }

# 1. The symlink farm (PR #140, src/idris-abi/) is retired.
if [ -e src/idris-abi ]; then say "FAIL: src/idris-abi exists (retired symlink farm)"; fail=1; fi
if [ -e src/idris-abi ] || [ -L src/idris-abi ]; then say "FAIL: src/idris-abi exists (retired symlink farm)"; fail=1; fi

# 2. Exactly one package file, and it is the one the gates name.
n=$(find src/abi -name '*.ipkg' | wc -l)
Expand Down
Loading