Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #126

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 55a2d697-91fd-47be-b1a7-8e9cf64fe98c

📥 Commits

Reviewing files that changed from the base of the PR and between 5f0bf08 and 9ce9e6c.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (32)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Security policy checks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: STATE vs dashboard reconciliation
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Groove manifest check
  • GitHub Check: Aspect Tests (Cross-Cutting)
  • GitHub Check: Criterion Benchmarks
  • GitHub Check: Rust Build + Unit Tests
  • GitHub Check: Zig FFI Build + Test
  • GitHub Check: E2E Lifecycle Test
  • GitHub Check: lint-workflows
  • GitHub Check: semgrep
  • GitHub Check: estate-audit
  • GitHub Check: lint-workflows
🧰 Additional context used
🪛 zizmor (1.30.0)
.github/workflows/governance.yml

[warning] 39-39: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

.github/workflows/mirror.yml

[warning] 20-20: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (2)
.github/workflows/governance.yml (1)

38-41: LGTM!

.github/workflows/mirror.yml (1)

19-22: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated governance automation to use a centralised, reusable workflow, improving consistency across repository checks.
    • Adjusted automation permissions for governance and mirroring tasks while preserving read-only access where applicable.
    • Maintained existing workflow triggers and concurrency behaviour.

Walkthrough

Both workflows move their permissions declarations from workflow scope to job scope. The permission values remain unchanged.

Changes

Workflow permission scope

Layer / File(s) Summary
Move permissions to job scope
.github/workflows/governance.yml, .github/workflows/mirror.yml
The governance and mirror jobs now declare actions: read, contents: read, and security-events: write at job scope.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: correcting invalid YAML permissions indentation in CI workflows.
Description check ✅ Passed The description explains the YAML parsing failure, the indentation correction, and the preserved permission grants. It directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions sit where jobs await
Read actions hop in line
Contents stay benign
Security events write just fine

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit cbfd349 into main Sep 21, 2026
21 of 36 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant