Repository navigation
ci(rust-ci): re-pin rust-ci-reusable past the toolchain-input breakage - #135
Conversation
Two anyhow::bail! calls in src/codegen/mod.rs were not rustfmt-clean. rust-ci never got far enough to report it: its toolchain step failed first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
rust-ci.yml called hyperpolymath/standards rust-ci-reusable at d135b05b. That version runs dtolnay/rust-toolchain by commit SHA without a `toolchain:` input; a SHA ref carries no version, so every run fails in the action's "parse toolchain version" step with "'toolchain' is a required input". d135b05b is the only standards pin in the estate without the fix (landed 2026-06-27). Re-pin to standards@95de3dfc, whose reusable passes `toolchain: stable`, and bring actions.lock's rust-ci.yml entry in line with it: - the workflow entry names hyperpolymath/standards@95de3dfc instead of [] (check-lock-sync flagged the job-level ref as missing); - add the hyperpolymath/standards@95de3dfc dependency record and the records for the four actions the reusable uses at that commit, copied verbatim from standards' own actions.lock at 95de3dfc. No existing lock record is changed or removed. standards' check-lock-sync.sh: rust-ci.yml leaves the failure list; nothing is added to it. Same fix as hyperpolymath/plasma-parser-writer#107, whose Rust CI is now green on main with this pin. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
Job-level reusable calls here (mirror, governance, secret-scanner, ...) have empty entries and no standards records, and they start fine. Adding a non-empty hyperpolymath/standards@95de3dfc entry made GitHub validate the call against the lock, and it rejected it for actions/checkout@3d3c42e5 with 'invalid lockfile pin'. Restore actions.lock to main so the PR only moves the pin, like the other reusable calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
…her reusables use 95de3dfc's reusable uses actions/checkout@3d3c42e5, the commit this repo's lock already pins as checkout@v7.0.1, and GitHub rejects it with 'invalid lockfile pin' (the job fails before any step runs). Every other reusable called here uses checkout@9c091bb2 and starts normally. 81dbf2dd has the toolchain fix, uses that same checkout ref, and is already the pin of this repo's governance and hypatia-scan callers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
|
🤖 Completed: Generate docstrings for PR #135 — View commit |
Summary
rust-ci.ymlcallshyperpolymath/standardsrust-ci-reusableatd135b05b. That version runsdtolnay/rust-toolchainby commit SHA without atoolchain:input, so every run fails with'toolchain' is a required inputbefore cargo starts.Re-pin to
standards@81dbf2dd, which passestoolchain: stable, uses the sameactions/checkout@9c091bb2as this repo's other reusables, and is already the pin of itsgovernanceandhypatia-scancallers.Changes
rust-ci.yml: pind135b05b→81dbf2dd.actions.lockuntouched.src/codegen/mod.rs: twoanyhow::bail!calls reformatted bycargo fmt. The format check could not report this before: the toolchain step failed first. Separate commit.Why not the newest standards commit:
95de3dfcusesactions/checkout@3d3c42e5, the commit this repo's lock records ascheckout@v7.0.1. GitHub rejects that withinvalid lockfile pin, failing the first job before any step. I tried it first, and also tried editing the lock; neither helped, so the final PR leaves the lock alone.RSR Quality Checklist
Required
cargo test --locked --all-targets, stable)cargo fmt --check)cargo clippy --locked --all-targets -- -D warnings).envfiles includedTesting
On this PR:
rust-ci / Detect Cargo.toml,Cargo check + clippy + fmtandCargo testall pass. Other red checks (Hypatia, DEED, K9, workflow security linter) are red onmaintoo and unrelated.🤖 Generated with Claude Code
https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye