Repository navigation
ci(rhodibot): switch to the report-only canary (standards#759) - #120
Conversation
The RSR workflow here is the mutating variant: weekly cron, write permissions,
glob deletes, a bulk SPDX `sed` sweep the licence policy forbids, a
`${{ steps.fix.outputs.FIXES }}` injection sink, and a hardcoded personal
e-mail. Replaced with the canary the template ships: same schedule, same drift
signal, reports instead of mutating.
Refs hyperpolymath/standards#759 (option (a), canary propagation).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (24)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe workflow is now a report-only RSR compliance canary. It no longer edits files, pushes branches, or creates pull requests. It reports detected drift, writes a step summary, and fails when would-mutate conditions are found. ChangesRSR Compliance Canary
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant actions/checkout
participant Canary shell
participant Step summary
GitHub Actions->>actions/checkout: Check out repository
actions/checkout-->>Canary shell: Provide repository contents
Canary shell->>Canary shell: Detect drift and advisory patterns
Canary shell->>Step summary: Write compliance results
Canary shell->>GitHub Actions: Emit error and exit 1 when drift exists
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the purpose, scope, security concerns, and related migration. It does not follow the repository template because it omits the Changes, RSR Quality Checklist, Testing, and Screenshots sections.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit watched the canary glow Comment |
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v4 | ||
| uses: actions/checkout@v7.0.1 |
The RSR workflow in this repository is the mutating variant of rhodibot: it runs on a
weekly cron with
contents: write+pull-requests: write, deletes files by glob, andbulk-rewrites SPDX headers — which the standing licence policy forbids. It also interpolates
${{ steps.fix.outputs.FIXES }}into arun:block (repo-derived filenames, soattacker-influenceable) and hardcodes a personal e-mail address.
This replaces it with the report-only canary that the estate template already ships — the
already-approved design, not a new one. Same weekly schedule, same drift signal, no mutation:
it reports what an auto-fixer would have changed and fails the run when it finds drift,
rather than editing anything. Licence/SPDX drift is reported for manual, owner-only
correction; rhodibot must never edit a licence header.
Part of the
standards#759migration (canary propagation, option (a)). The workflow'suses:pins are unchanged, so
actions.lockis unaffected.