Repository navigation
fix(deps): bump hickory-proto 0.25.2 -> 0.26.3 - #100
Merged
Merged
Conversation
hickory-proto 0.25.2 is inside GHSA-q2qq-hmj6-3wpp (<= 0.26.0) and GHSA-3v94-mw7p-v465 (0.25 line, no patched 0.25 release). Move both crates to ^0.26.3 and port to the 0.26 message API, which replaced Header getters/setters with public Metadata fields: - Header::response_from_request -> Metadata::response_from_request - message.queries()/answers() -> message.queries/answers fields - set_response_code/set_op_code/... -> message.metadata.* fields - Record::set_dns_class -> record.dns_class; TXT::iter -> txt_data - rr::record_data::RData is private; import rr::RData Also replace a let-chain in hesinfo's validate command with a nested if-let: the workspace is edition 2021, so origin/main did not compile (E: let chains are only allowed in Rust 2024). Refs hyperpolymath/.git-private-farm#96 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Add Carrot credits or activate Agent usage billing to use Autopilot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Refs hyperpolymath/.git-private-farm#96 (owner ruling D138: accept the major bump and fix breakage).
What
hickory-proto0.25.2->0.26.3incrates/hesiod-libandcrates/hesinfo, withCargo.lockat 0.26.3. The floor is0.26.3, not0.26, so the manifest requirement no longer admits the affected 0.26.0.Headergetters and setters with publicMetadataand section fields:Header::response_from_request->Metadata::response_from_requestqueries()/answers()->.queries/.answers;set_response_code,set_idand similar ->.metadata.*Record::set_dns_class->.dns_class;TXT::iter->.txt_data;rr::record_data::RDatais now private, so importrr::RDatahesinfo's validate command used a let-chain, but the workspace isedition = "2021".origin/main(3bd657b) does not compile (error: let chains are only allowed in Rust 2024 or later,crates/hesinfo/src/main.rs:245). I rewrote it as a nestedif letwith the same behaviour.Resolves Dependabot alerts #2 (GHSA-3v94-mw7p-v465,
>= 0.25.0-alpha.3, <= 0.25.2) and #3/#4/#5 (GHSA-q2qq-hmj6-3wpp,>= 0.3.1, <= 0.26.0). The locked 0.26.3 is outside both ranges.Cargo.lockalso gainsjni*,rand 0.10-family andsimd_cesu8entries. These are hickory-proto 0.26's target-specific (Android) and RNG dependencies and are not compiled on Linux.Verification (local, rustc 1.97.1)
cargo build --locked: ok (origin/main fails here, see above)cargo test --locked: ok, 7 suites, 70 passed, 0 failedcargo clippy --locked: no warningshesinfo serveon :15353, thendig -c HS -t TXT admin.passwd.ns.flatracoon.internalreturned NOERROR with theaaflag and the correct TXT answer. An unknown key returned NXDOMAIN.cargo fmt --checkfails on main and on this branch. Every reported diff is in lines this PR does not touch (benches, tests, health.rs and others). Left as is to keep this diff minimal.Not fixed here (pre-existing):
hesinfo lookupqueries<key>.<map>.nswithout the zone suffix, so it gets NXDOMAIN from the server.🤖 Generated with Claude Code