Skip to content

fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints - #85

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/julia-sqlite-uuid-and-entrypoints
Oct 24, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/julia-sqlite-uuid-and-entrypoints

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Fix SQLite UUID (0aa819cd-b072-5ff4-a722-6bc24af294d9), declare SparseArrays/FFTW, and add src/EconomicToolkit.jl + test/runtests.jl shims for Pkg.test().

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9a8e15d1-ca7e-4b35-ba0a-cec2dd4b4894
Commits

Reviewing files that changed from the base of the PR and between 44e2683 and 6bca37c.

Files selected for processing: 3
  • Project.toml
  • src/EconomicToolkit.jl
  • test/runtests.jl

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 37
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: build
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: scan / rust-secrets
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: integration-tests (1.10, 3.12, 4.3)
  • GitHub Check: integration-tests (1.10, 3.11, 4.3)
  • GitHub Check: analyze (cpp, none)
  • GitHub Check: Validate DEED manifests
  • GitHub Check: analyze (javascript-typescript, none)
  • GitHub Check: integration-tests (1.10, 3.10, 4.3)
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate K9 contracts
  • GitHub Check: security
  • GitHub Check: lint-typescript
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: build
  • GitHub Check: test-julia
  • GitHub Check: test-typescript
  • GitHub Check: security
  • GitHub Check: lint-julia
  • GitHub Check: semgrep-cloud-platform/scan
CI failures not shown inline: 8

GitHub Actions: Hypatia Security Scan / 0_hypatia _ Hypatia Neurosymbolic Analysis.txt: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Actions: read
 Contents: read
 Metadata: read
 SecurityEvents: write
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]lockfile verification did not produce a result for this action. Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile. lockfile verification did not produce a result for this action. lockfile verification did not produce a result for this action. lockfile verification did not produce a result for this action

GitHub Actions: Hypatia Security Scan / hypatia _ Hypatia Neurosymbolic Analysis: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Actions: read
 Contents: read
 Metadata: read
 SecurityEvents: write
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]lockfile verification did not produce a result for this action. Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile. lockfile verification did not produce a result for this action. lockfile verification did not produce a result for this action. lockfile verification did not produce a result for this action

GitHub Actions: Secret Scanner / 0_scan _ gitleaks.txt: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile

GitHub Actions: Secret Scanner / scan _ gitleaks: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile

GitHub Actions: Secret Scanner / 1_scan _ shell-secrets.txt: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile

GitHub Actions: Secret Scanner / scan _ shell-secrets: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile

GitHub Actions: Secret Scanner / 2_scan _ rust-secrets.txt: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile

GitHub Actions: Secret Scanner / scan _ rust-secrets: fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Using locked action versions from the workflow's lockfile
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]Unable to resolve action `actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1`: invalid lockfile pin. Run `gh actions-lock` to update the lockfile
Additional comments: 3
Project.toml: 1

11-11: LGTM!

Also applies to: 18-19, 29-29

src/EconomicToolkit.jl: 1

1-2: LGTM!

test/runtests.jl: 1

1-2: LGTM!

📝 Summary

Summary by CodeRabbit

  • Chores

    • Updated package configuration and licensing information.
  • Tests

    • Added additional automated test coverage for the Julia components.

The project metadata adds dependencies and FFTW compatibility, and changes the SQLite UUID. The package module includes the Julia implementation. The test entry point includes the Julia test runner and client tests.

Changes: Julia package integration

Layer / File(s) Summary
Package and test entry points
Project.toml, src/EconomicToolkit.jl, test/runtests.jl
The project adds SparseArrays and FFTW, updates the SQLite UUID, and declares FFTW compatibility. The package module includes the Julia implementation. The test entry point includes the Julia runner and client tests. The source and test entry points add SPDX licence identifiers.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 6bca3

No actionable merge-blocking risk remains in the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description accurately summarises the SQLite UUID correction, dependency declarations, and Pkg.test() entrypoint shims.
Title check Passed The title clearly and concisely identifies the SQLite UUID correction, SparseArrays and FFTW declarations, and Pkg entrypoints.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T11:18:39.728744Z 6bca37c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bca37cfc4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/EconomicToolkit.jl
@@ -0,0 +1,2 @@
# SPDX-License-Identifier: MPL-2.0
include("julia/EconomicToolkit.jl")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a module-qualified include in the package entrypoint

When loading the package with using EconomicToolkit, Julia evaluates this entrypoint in Base.__toplevel__, a bare module without the single-argument include helper. Consequently, this shim raises UndefVarError: include not defined, preventing package loading and precompilation. The existing inner file defines the module, so delegate with Base.include(@__MODULE__, "julia/EconomicToolkit.jl") instead. This follows the loading context and include definitions in Julia 1.10's loader.

Useful? React with 👍 / 👎.

Comment thread test/runtests.jl
Comment on lines +2 to +3
include(joinpath(@__DIR__, "..", "tests", "julia", "runtests.jl"))
include(joinpath(@__DIR__, "..", "tests", "julia", "test_client.jl"))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Isolate the legacy and package-client test namespaces

Including both suites in the same module contaminates the client tests: tests/julia/runtests.jl first includes standalone formula implementations that define elasticity, gdp_growth, and other functions in the current namespace. The subsequent using EconomicToolkit in test_client.jl cannot replace those bindings, so its unqualified calls resolve to the legacy implementations. For example, the client test's elasticity(...; method="point") reaches the legacy method requiring a Symbol, and its one-argument gdp_growth(gdp) has no matching legacy method. Run the suites in separate modules or qualify the client calls so the new Pkg.test() entrypoint actually tests the package API without these failures.

Useful? React with 👍 / 👎.

@hyperpolymath
hyperpolymath merged commit 4f89616 into main Oct 24, 2026
15 of 42 checks passed
@hyperpolymath
hyperpolymath deleted the fix/julia-sqlite-uuid-and-entrypoints branch October 24, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant