Repository navigation
fix(julia): correct SQLite UUID, declare SparseArrays/FFTW, and add Pkg entrypoints - #85
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Package and test entry points Project.toml, src/EconomicToolkit.jl, test/runtests.jl |
The project adds SparseArrays and FFTW, updates the SQLite UUID, and declares FFTW compatibility. The package module includes the Julia implementation. The test entry point includes the Julia runner and client tests. The source and test entry points add SPDX licence identifiers. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Merge Risk: 
Minimal · up to 6bca3
-
No actionable merge-blocking risk remains in the reviewed changes.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bca37cfc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,2 @@ | |||
| # SPDX-License-Identifier: MPL-2.0 | |||
| include("julia/EconomicToolkit.jl") | |||
There was a problem hiding this comment.
Use a module-qualified include in the package entrypoint
When loading the package with using EconomicToolkit, Julia evaluates this entrypoint in Base.__toplevel__, a bare module without the single-argument include helper. Consequently, this shim raises UndefVarError: include not defined, preventing package loading and precompilation. The existing inner file defines the module, so delegate with Base.include(@__MODULE__, "julia/EconomicToolkit.jl") instead. This follows the loading context and include definitions in Julia 1.10's loader.
Useful? React with 👍 / 👎.
| include(joinpath(@__DIR__, "..", "tests", "julia", "runtests.jl")) | ||
| include(joinpath(@__DIR__, "..", "tests", "julia", "test_client.jl")) |
There was a problem hiding this comment.
Isolate the legacy and package-client test namespaces
Including both suites in the same module contaminates the client tests: tests/julia/runtests.jl first includes standalone formula implementations that define elasticity, gdp_growth, and other functions in the current namespace. The subsequent using EconomicToolkit in test_client.jl cannot replace those bindings, so its unqualified calls resolve to the legacy implementations. For example, the client test's elasticity(...; method="point") reaches the legacy method requiring a Symbol, and its one-argument gdp_growth(gdp) has no matching legacy method. Run the suites in separate modules or qualify the client calls so the new Pkg.test() entrypoint actually tests the package API without these failures.
Useful? React with 👍 / 👎.
Fix
SQLiteUUID (0aa819cd-b072-5ff4-a722-6bc24af294d9), declareSparseArrays/FFTW, and addsrc/EconomicToolkit.jl+test/runtests.jlshims forPkg.test().