Repository navigation
ci(secret-scan): canonical estate scanner caller, key scan (D243) - #107
Conversation
Secret-Scan-Floor (D243/D244) requires the context `scan / gitleaks` estate-wide. The previous inline scanner jobs emitted bare contexts (e.g. `gitleaks`) that cannot satisfy the floor; the reusable deliberately drops TruffleHog as redundant with gitleaks. Write the canonical caller: job key `scan`, reusable pinned to standards@74d2f66, push trigger on the default branch `main`. actionlint: new file clean (findings in previous file: 0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
…aller The caller's only uses: is a job-level reusable workflow, which actions.lock does not track; the stale step entries left from the inline scanner made GitHub refuse to start the workflow (startup_failure, jobs=0). Verified: standards check-actions-lock-gate.sh rc=0 and gh actions-lock --no-fix valid=true. gh actions-lock does not rewrite this key itself (D283). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
|
| Layer / File(s) | Summary |
|---|---|
Reusable scanner workflow .github/workflows/secret-scanner.yml |
The workflow documents the shared scanner and required scan / gitleaks check. It replaces the TruffleHog, Gitleaks, and Rust-secret jobs with one scan job that calls the pinned reusable workflow. |
Priority: ⬇️ Low
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: ⚪ Minimal · up to 480be
The pinned shared scanner and updated lock entry show no established merge-blocking issue. The exact emitted check name remains unconfirmed.
Architecture Summary
Architecture risk: 🔵 Low · up to 480be
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
- observed — Modified behavior in .github/workflows/secret-scanner.yml: The workflow documentation now describes the shared secret scanner, required
scan / gitleakscheck context, and absence ofsecrets:; it replaces the management comment and prior one-line description. - observed — Modified behavior in .github/workflows/secret-scanner.yml: The
trufflehog,gitleaksandrust-secretsjobs and their local scanning steps are removed. A singlescanjob now calls the pinned shared reusable workflow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the CI secret-scanning change and the canonical scanner caller. It is specific to the main change. |
| Description check | ✅ Passed | The description directly explains the workflow change, the required scan / gitleaks context, the reusable workflow, and the reason for removing the inline scanners. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the scanner’s trail
One shared workflow guards the rail
Three old jobs hop away
A pinned call runs each day
Secrets stay out of sight
The check returns right
Comment @coderabbitai help to get the list of available commands.
What
Write the canonical estate secret-scanner caller to
.github/workflows/secret-scanner.ymlso this repo emitsscan / gitleaks, the context the estate Secret-Scan-Floor ruleset (D243/D244) requires. The previous inline scanner jobs emitted bare contexts (e.g.gitleaks) that cannot satisfy the floor; the reusable deliberately drops TruffleHog as redundant with gitleaks.Job key
scan; reusablehyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@74d2f66f575246cf6e313ae7775f44df6e097ff2; push trigger onmain. actionlint clean (previous file findings: 0). Commit via GraphQLcreateCommitOnBranch(GitHub-signed, valid: true).🤖 Generated with Claude Code
https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK