Repository navigation
feat(ci): package-registry provenance - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds native package-registry provenance to the in-scope publish flows in
.github/workflows/release.yml.Cargo (crates.io) — DONE
crates.io has no native OIDC provenance, so we attest the built
.crateartifact via GitHub build-provenance:publish-cratesjobpermissions:now includesid-token: writeandattestations: write(keptcontents: read).cargo packagestep (single root crate, default working-dir →target/package/bunsenite-<ver>.crate).actions/attest-build-provenance@e8998f949152b193b063cb0ec769d69d929409be # v2withsubject-path: 'target/package/*.crate', run beforecargo publish.cargo publish --no-verifyunchanged — publishing not altered.npm (npmjs) — SKIPPED, needs-bespoke
The
publish-npmjob does a genuine public publish (npm publish --access publicinbindings/rescript, registryregistry.npmjs.org). Provenance was not added becausebindings/rescript/package.jsonhasrepository.urlpointing to GitLab (gitlab.com/.../bunsenite.git), not this GitHub repo.npm publish --provenancerequires the manifestrepository.urlto match the GitHub build repository, so enabling it would fail the publish. Per the "never break publishing" constraint this is left as needs-bespoke: fixrepository.urlto the GitHub repo (and bump the staleversion: 1.0.0) first, then addid-token: write+--provenance.Out of scope (untouched)
Distro / OS packagers were explicitly out of scope and not modified:
publish-aur.yml,publish-chocolatey.yml,publish-container.yml,publish-copr.yml,publish-debian-ppa.yml,publish-flatpak.yml,publish-homebrew.yml,publish-macports.yml,publish-nixpkgs.yml,publish-obs.yml,publish-packages.yml,publish-scoop.yml,publish-winget.yml, plusghcr-publish.yml.