Repository navigation
docs: add Signed commits section to CONTRIBUTING - #156
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (28)
|
| Layer / File(s) | Summary |
|---|---|
Signing and merge requirements .github/CONTRIBUTING.md |
The guide describes signing requirements, signing methods, and the rules for unsigned commits and merge types. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to 61199
This change adds signed-commit guidance to the contribution guide and does not alter runtime behavior. It is ready to merge.
Architecture Summary
Architecture risk: 🔵 Low · up to 61199
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
- observed — Modified behavior in .github/CONTRIBUTING.md: Adds signed-commit requirements and signing instructions for people, interactive agents, apps, bots and workflows. Specifies squash merges, explains that any unsigned commit on the PR branch blocks the merge, directs contributors to recreate such a branch with signed commits, and states that rebase-merge is disabled.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely describes the main change: adding a Signed commits section to CONTRIBUTING. |
| Description check | ✅ Passed | The description clearly relates to the documentation change and explains the signing policy, contributor guidance, and merge requirements. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit signs each commit with care,
Then checks the branch before the merge.
Squash keeps the final changes neat,
No unsigned hops pass through the gate.
The guide now marks the path to take.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The documentation accurately reflects the linked signing policy with no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds repository commit-signing guidance aligned with estate policy D218.
Changes:
- Documents SSH signing for people and interactive agents.
- Documents API-based signing for automation.
- Requires squash merging and explains unsigned-commit remediation.
| File | Description |
|---|---|
.github/CONTRIBUTING.md |
Adds signed-commit and merge guidance. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f