Skip to content

Coderabbit/fix ci validation failures/985fde70 - #183

Merged
hyperpolymath merged 5 commits into
mainfrom
coderabbit/fix-ci-validation-failures/985fde70
Sep 12, 2026
Merged

hyperpolymath merged 5 commits into
mainfrom
coderabbit/fix-ci-validation-failures/985fde70

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers

hyperpolymath and others added 3 commits September 9, 2026 09:35
A patch-application sweep left `.rej` and `.orig` files committed under
.github/workflows/. They are inert — GitHub only reads `.yml` there — but they
are actively misleading, and one of them is dangerous to re-apply.

Every rejected hunk is an OBSOLETE pin bump. They target 892497fe / 7fdc2705 /
d135b05b / 81dbf2dd / c65436ee, all of which are superseded by the current
governance pin; PR #177 already moves these same five workflows to the live
target. Re-applying any of this would move pins BACKWARDS.

scorecard.yml.rej is worse than obsolete. Its hunk rewrites the permissions
block to:

    jobs:
      analysis:
        permissions:
      contents: read
      security-events: write

which is unparseable — the same naive string-splicing permissions sweep that
left scorecard.yml invalid in ten other repositories. An unparseable workflow
does not fail its gate, it produces ZERO jobs and therefore no check at all, so
the repo scores GREENER than a repaired one. This repo escaped only because the
hunk rejected instead of applying.

Verified before deleting: all 20 live workflows under .github/workflows/ parse
as valid YAML, scorecard.yml included, so no live file depends on this debris
and no unlanded fix is discarded by removing it.

Touches only `.rej`/`.orig` paths. No overlap with the five `.yml` files open
PR #177 edits, so the two cannot conflict.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: fe600296-6ad1-491b-85c6-c726e1224c64

📥 Commits

Reviewing files that changed from the base of the PR and between e442221 and 02bc8b6.

📒 Files selected for processing (9)
  • .github/workflows/elixir-ci.yml.rej
  • .github/workflows/governance.yml.orig
  • .github/workflows/governance.yml.rej
  • .github/workflows/mirror.yml.rej
  • .github/workflows/scorecard.yml.orig
  • .github/workflows/scorecard.yml.rej
  • .github/workflows/secret-scanner.yml.orig
  • .github/workflows/secret-scanner.yml.rej
  • audits/assail-classifications.a2ml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 9bddc1c into main Sep 12, 2026
14 checks passed
@hyperpolymath
hyperpolymath deleted the coderabbit/fix-ci-validation-failures/985fde70 branch September 12, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant