Repository navigation
chore(ci): delete 8 committed patch-debris files (.rej/.orig) - #178
Conversation
A patch-application sweep left `.rej` and `.orig` files committed under .github/workflows/. They are inert — GitHub only reads `.yml` there — but they are actively misleading, and one of them is dangerous to re-apply. Every rejected hunk is an OBSOLETE pin bump. They target 892497fe / 7fdc2705 / d135b05b / 81dbf2dd / c65436ee, all of which are superseded by the current governance pin; PR #177 already moves these same five workflows to the live target. Re-applying any of this would move pins BACKWARDS. scorecard.yml.rej is worse than obsolete. Its hunk rewrites the permissions block to: jobs: analysis: permissions: contents: read security-events: write which is unparseable — the same naive string-splicing permissions sweep that left scorecard.yml invalid in ten other repositories. An unparseable workflow does not fail its gate, it produces ZERO jobs and therefore no check at all, so the repo scores GREENER than a repaired one. This repo escaped only because the hunk rejected instead of applying. Verified before deleting: all 20 live workflows under .github/workflows/ parse as valid YAML, scorecard.yml included, so no live file depends on this debris and no unlanded fix is discarded by removing it. Touches only `.rej`/`.orig` paths. No overlap with the five `.yml` files open PR #177 edits, so the two cannot conflict. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details
|
| Layer / File(s) | Summary |
|---|---|
Reusable workflow reference updates .github/workflows/elixir-ci.yml.rej, .github/workflows/governance.yml.rej, .github/workflows/mirror.yml.rej, .github/workflows/secret-scanner.yml.rej |
The files reference newer pinned commits for the Elixir CI, governance, mirror, and secret-scanner reusable workflows. |
Obsolete workflow artefact removal .github/workflows/governance.yml.orig, .github/workflows/scorecard.yml.orig, .github/workflows/scorecard.yml.rej, .github/workflows/secret-scanner.yml.orig |
The obsolete governance, Scorecards, and Secret Scanner workflow artefacts were deleted. |
Priority: ⬇️ Low
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk: ⚪ Minimal · up to 8c5ad
This change removes obsolete workflow patch artifacts without modifying live workflow files. No current merge-readiness risk is identified.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely describes the deletion of the eight committed .rej and .orig patch-debris files. |
| Description check | ✅ Passed | The description directly explains the deleted patch-debris files, their obsolete and invalid contents, and the validation performed. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🛠️ Fix failing CI checks
- Create stacked PR
- Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks each pinned flow
Old workflow scraps now softly go
Governance rests, scans depart
Fresh commit hashes mark the start
The CI burrow runs neat and bright
Comment @coderabbitai help to get the list of available commands.
|
✅ Coding Agent task started: View task and status The task will inspect the CI failures, validate its fix, and open a stacked fix pull request automatically.
⏭️ 5 check(s) skipped — already failing on `main` (not caused by this PR)
|
Add SPDX, name, project, and version metadata to the ASSAIL classifications manifest, and nest its existing security suppressions under a top-level list for CI-compatible validation. Validation: `git diff --check` passes; no broader test suite was run. [View coding task](https://app.coderabbit.ai/code/tasks/985fde70-d434-43dd-9729-e1c7dd0a7a5d?source=coding_agent_github_pr_description) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
A patch-application sweep left
.rejand.origfiles committed under.github/workflows/. GitHub only reads.ymlfrom that directory, so they are inert — but they are actively misleading, and one is dangerous if anyone ever re-applies it.Every rejected hunk is an obsolete pin bump
They target
892497fe/7fdc2705/d135b05b/81dbf2dd/c65436ee, all superseded by the current governance pin. Open PR #177 already moves these same five workflows to the live target, so re-applying any of this debris would move pins backwards.scorecard.yml.rejis worse than obsoleteIts hunk rewrites the permissions block to:
That is unparseable. It is the same naive string-splicing permissions sweep that left
scorecard.ymlinvalid in ten other repositories. An unparseable workflow does not fail its gate — it produces zero jobs and therefore no check at all, so the repo scores greener than a repaired one. This repo escaped only because the hunk rejected instead of applying.Verified before deleting
.github/workflows/parse as valid YAML,scorecard.ymlincluded — no live file depends on this debris and no unlanded fix is discarded..rej/.origpaths. No overlap with the five.ymlfiles PR fix(ci): pin standards reusables to default-branch HEAD #177 edits, so the two cannot conflict.🤖 Generated with Claude Code
https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB