Repository navigation
Clarify configure_repo failure and return semantics - #380
coderabbitai[bot] wants to merge 3 commits into
Conversation
configure-all-repos.sh wrote its audit log to the fixed path
/tmp/repo-config.log. A predictable /tmp path lets another local user
pre-create, symlink, or race the file before this script runs.
LOG_FILE now resolves under the XDG state home
(${XDG_STATE_HOME:-$HOME/.local/state}/personal-sysadmin/repo-config.log),
with the parent directory created mode 0700 before the first write
(split into `mkdir -p` + `chmod 0700` rather than `mkdir -p -m 0700`, to
avoid a new shellcheck SC2174 warning; the leaf directory still ends up
0700). Every `$LOG_FILE` expansion is now double-quoted.
This is a durable operator audit log (bookended "Starting configuration
at ..." / "Configuration complete at ..." messages), not scratch, so it
keeps a stable, re-findable path rather than moving to mktemp -d.
/tmp/repos-to-configure.txt (lines using it are unchanged) is a
durable, shared cache read by 9 sibling scripts in this directory and
is deliberately NOT touched here -- converting it to ephemeral scratch
would break all 9 consumers. Tracked separately:
#377
Verification: bash -n OK; shellcheck clean (matches baseline, only the
pre-existing SC2162 on the `while read repo` loop); grep -nE
"[\"'/]tmp/" shows exactly the 3 untouched repos-to-configure.txt
lines (64, 65, 73), 0 hits on any touched line.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Closing as superseded. #379 (181076c) landed the 🤖 Generated with Claude Code |
Document that API failures in configure_repo do not stop subsequent requests and that its return status comes from the final tee command, so success does not confirm repository configuration. This change adds comments only.
Validation: inspected the pinned diff and function implementation; tests were not run.
View coding task