Repository navigation
Commit bb663fe
fix(ci): unblock the source-lint gate on the newly-added test files (#88)
Follow-up to #85, which restored workflow startup. With CI alive again,
the **Source lint** step (`config/ci/lint_source.jl`) produced its first
verdict in two days and failed on two files it had never been able to
run against — neither of them touched by #85:
1. **`test/doi/fixtures.jl`** uses the suite aliases `B`/`P`, which are
`const` bindings defined in `tests.jl` before `include("fixtures.jl")`.
The lint check is deliberately textual and per-file, so an alias
supplied by the includer is invisible to it. The three call sites
(`B.write_checksums!`, `P.prepare!`, `P.publish!`) now go through
`Target.DOIBundles` / `Target.DOIPublications` — the same bindings at
runtime (tests.jl defines them from `Target`), legible in isolation.
2. **`test/unit/test_zero_replacement.jl:215`** broadcast
`Float64.(parse.(Float64, ...))` — the outer map is an identity (`parse`
with a `Float64` target already yields `Float64`), and the `Float64.(`
spelling matches the lint's `Module.member` pattern over test files.
Removing the outer conversion changes no value.
**Validation:** replayed the lint's textual checks (escaped
interpolation, adjacent docstrings, bare-alias member refs, the
`Float64.( pattern`) over both files — all clean. Julia itself isn't
available in this sandbox, so the definitive gate is the CI Source lint
step on this PR.
**Known-red checks NOT addressed here** (pre-existing, not introduced by
this change): repo-hygiene `tsc --noEmit` (frontend, likely #83-era),
the stale apt-Agda 2.6.4.3 `Proofs (Agda)` job inside ci.yml (proofs.yml
— the real gate — is green), and the DOI contracts job.
Co-authored-by: arena-agent <arena-agent@users.noreply.github.com>
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>1 parent c180900 commit bb663fe
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
0 commit comments