Skip to content

Commit bb663fe

Browse files
fix(ci): unblock the source-lint gate on the newly-added test files (#88)
Follow-up to #85, which restored workflow startup. With CI alive again, the **Source lint** step (`config/ci/lint_source.jl`) produced its first verdict in two days and failed on two files it had never been able to run against — neither of them touched by #85: 1. **`test/doi/fixtures.jl`** uses the suite aliases `B`/`P`, which are `const` bindings defined in `tests.jl` before `include("fixtures.jl")`. The lint check is deliberately textual and per-file, so an alias supplied by the includer is invisible to it. The three call sites (`B.write_checksums!`, `P.prepare!`, `P.publish!`) now go through `Target.DOIBundles` / `Target.DOIPublications` — the same bindings at runtime (tests.jl defines them from `Target`), legible in isolation. 2. **`test/unit/test_zero_replacement.jl:215`** broadcast `Float64.(parse.(Float64, ...))` — the outer map is an identity (`parse` with a `Float64` target already yields `Float64`), and the `Float64.(` spelling matches the lint's `Module.member` pattern over test files. Removing the outer conversion changes no value. **Validation:** replayed the lint's textual checks (escaped interpolation, adjacent docstrings, bare-alias member refs, the `Float64.( pattern`) over both files — all clean. Julia itself isn't available in this sandbox, so the definitive gate is the CI Source lint step on this PR. **Known-red checks NOT addressed here** (pre-existing, not introduced by this change): repo-hygiene `tsc --noEmit` (frontend, likely #83-era), the stale apt-Agda 2.6.4.3 `Proofs (Agda)` job inside ci.yml (proofs.yml — the real gate — is green), and the DOI contracts job. Co-authored-by: arena-agent <arena-agent@users.noreply.github.com> Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
1 parent c180900 commit bb663fe

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎test/doi/fixtures.jl‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function bundle_fixture(root; result=false, mock=false, dangerous=false)
3131
"method" => "nb_glm", "provenance" => Dict("mock" => mock),
3232
"results" => Dict("synthetic_fixture" => Dict("status" => "fixture")))))
3333
end
34-
B.write_checksums!(dir)
34+
Target.DOIBundles.write_checksums!(dir)
3535
return dir
3636
end
3737

@@ -102,13 +102,13 @@ function prepared_fixture(f; result=false, dangerous=false, environment="sandbox
102102
root = joinpath(tmp, "publications")
103103
fake = FakeZenodo(; environment)
104104
c = client(fake)
105-
prepared = P.prepare!(root, source, metadata_fixture(), c)
105+
prepared = Target.DOIPublications.prepare!(root, source, metadata_fixture(), c)
106106
f(tmp, root, source, fake, c, prepared)
107107
end
108108
end
109109

110110
function publish_fixture(root, prepared, c)
111-
P.publish!(root, prepared["id"], c; confirmation=prepared["confirmation_phrase"],
111+
Target.DOIPublications.publish!(root, prepared["id"], c; confirmation=prepared["confirmation_phrase"],
112112
bundle_sha256=prepared["bundle_sha256"], acknowledge_public=true)
113113
end
114114

‎test/unit/test_zero_replacement.jl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ vector(vals)::Vector{Float64} = Float64[Float64(v) for v in vals]
212212
write.table(r, stdout(), sep = ",", row.names = FALSE, col.names = FALSE)
213213
"""
214214
r_out = read(`$rscript -e $script`, String)
215-
rows = [Float64.(parse.(Float64, split(l, ","))) for l in
215+
rows = [parse.(Float64, split(l, ",")) for l in
216216
split(strip(r_out), "\n") if !isempty(strip(l))]
217217
reference = permutedims(Matrix{Float64}(hcat(rows...)), (1, 1))
218218
ours = multiplicative_replacement(counts; delta = Float64(mr.delta))

0 commit comments

Comments
 (0)