You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a6e30fa
Browse filesBrowse the repository at this point in the historyBrowse files
authored
fix: load the package, and restore the docs and test registrations main lost (#209)
Rebased onto `main` (c978994, which now carries #208/#211/#213), so this
PR is only the part `main` still gets wrong — and `main` still cannot
load the package.
## 1. `using MetaManifold` fails
| File | Defect | Effect |
|---|---|---|
| `src/core/doi.jl` | `module DOI` declared twice (lines 4 and 21) with
one terminator | `ParseError` at EOF, before a single test runs |
| `src/MetaManifold.jl` | `analysis/clade_cumulus.jl` included twice;
`analysis/compositional.jl` never included | module redefined;
`UndefVarError: CompositionalModels` when `differential.jl` loads |
| `src/server/server.jl` | `routes/cladistics.jl` never included | the
Cladistics tab calls endpoints that return 404 while the route file sits
unused |
Each is a one-line fix in place. `cladistics.jl` is included after
`clade_cumulus.jl`; it shares no route path or helper name with the
other route files.
## 2. Test registration
`test/runtests.jl` listed `test_clade_cumulus.jl` twice and had lost
`test_evidence.jl` and `test_evidence_routes.jl`, which #201 added. Now
49 files, each once, and every file in `test/unit` is registered.
## 3. Two statistics tests that contradicted their own sources
Both came from a branch whose tests were written against different
source behaviour:
- `test_exact_summaries.jl` expected `0/1` proportions for a zero-read
sample. `_summarise` fills them with `nothing` and stores null, because
a proportion is undefined — not zero — when a sample has no reads. The
test is realigned to the source; the source is not weakened to the test.
- `test_high_precision.jl` expected `UnsupportedRepresentationError` for
a policy of the wrong numeric mode. `assert_mode` raises `ArgumentError`
for that (a caller error, not an unrepresentable value). Realigned, with
the reason stated inline.
## 4. Documentation main lost in the #196 merge
- `docs/statistics/zero-handling.md` is back to the full treatment —
replacement policies and their exact `cmultRepl` calls, `delta`
semantics, what the Bayesian posterior parameterisation does and does
**not** claim, warnings, and references — instead of the 60-line
summary.
- `README.md` regains the Evidence Mode section and the
differential-abundance method guidance (why a count model rather than a
t-test, choosing the reference taxon, overdispersion, which model to
use), documents all nine methods and their settings, and the config
sample lists every differential key including the multinomial optimiser
budget.
## Validation
Julia is not available in my environment, so the Julia side is static:
tree-sitter parses every touched file, no file is included twice, every
`test/unit` file is registered exactly once, and the YAML parses with
the expected differential keys. Frontend: `npx tsc --noEmit` clean, `bun
test src` 85/85, `npm run build` succeeds. CI is the first real
execution of the Julia suite, and I will follow it and fix what it
reports.
Co-authored-by: Arena Agent <agent@arena.ai>
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
0 commit comments