feat: add Fabric snapshot to Fabric X migration RFC - #68
Conversation
c717237 to
cef9a77
Compare
Signed-off-by: Anton Antonov <anton.synd.antonov@gmail.com>
c0a568a to
9ee3afa
Compare
PoC testing coverageThe migration integration test uses the exporter and disposable Fabric and Fabric-X networks. The primary path:
The integration scenarios cover:
The rebuild scenario reuses the original bundle. It does not test whether a replacement bundle is rejected after the database-local migration record has been lost. The committer bootstrap tests cover the failure paths separately: atomic rollback, missing or non-empty namespaces, existing transaction IDs, missing block Run the focused tests with: go test ./cmd/committer ./service/vc
go test -tags=integration ./integration/migration \
-run TestInitFromSnapshot \
-count=1 -v |
| ## Omit Fabric transaction IDs | ||
|
|
||
| Rejected because a transaction committed before `H` could be submitted to the | ||
| target again. Version `1` imports the IDs into `migrated_tx_ids`, and normal | ||
| duplicate detection checks that immutable registry together with `tx_status`. | ||
| The importer does not invent Fabric-X status or height values for source | ||
| transactions. |
There was a problem hiding this comment.
On a second note, not needed since they'll be rejected. To be removed from the snapshot and import.
Extra point - have an integration test verify this.
Description
This RFC defines an offline migration from a Fabric Classic peer snapshot to
Fabric-X.
It specifies:
hashes as public state;
B; andrecovery.
Source block history, online migration, PDC values, automatic chaincode
translation, and channel consolidation are outside this proposal.
Proof of concept
Related issues
cc @liran-funaro @cendhu @tock-ibm