Repository navigation
fix(rust): bake and use only the designated LLVM version - #529
Merged
Merged
Conversation
toolchains/llvm.yaml now bakes one LLVM major, versions.yaml `llvm`, through a new ${HYPERCI_LLVM_DEFAULT} placeholder. The 19-22 entries and the libc++/lldb install-on-demand entry are gone. They existed only for the ClickHouse fork's C++ build, which is no longer built. HYPERCI_LLVM_VERSION and build.rust.llvm_version do not reach toolchains/llvm.yaml, so the baked toolchain and the image's clang and ld.lld alternatives always name the same major. The native-deps entries in the same install-all run still follow the designated major. default_llvm_major() raises LLVMVersionError for a missing runtimes.llvm, so a bad versions.yaml fails the install with an error line, not a KeyError traceback.
native-deps/rust.yaml installs clang-NN at the designated major from apt.llvm.org, only for a repo whose .cargo/config.toml links through clang. Every other Rust job skips the apt.llvm.org fetch and the libclang1-NN that comes with it. A PGO build shims clang and clang++ to the designated major the way it shims ld.lld. The clang shim is separate, so a runner without clang-NN leaves ld.lld on PATH at the designated major. The clang it falls back to links with its own major's lld, and the warning names that major.
The Go default targets and the `all` shortcut drop windows/amd64. The explicit `windows` shortcut stays.
rust-llvm.md, runner-image.md, runners.md and the Rust troubleshooting, tier 2 and release verification docs describe the single baked major, the clang shim and the arc-runner-native bake, and drop the C++ runner text.
Closes #519
Both are C/C++ editor and analysis tools. No Rust build, link, PGO or BOLT step uses them.
Contributor
|
Released in v2.12.17 -- https://github.com/hyperi-io/hyperi-ci/releases/tag/v2.12.17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #519.
The ARC runner image bakes one LLVM major, the
llvmdefault in versions.yaml (23), instead of 19-23. The extra majors existed only for the retired ClickHouse C++ fork.toolchains/llvm.yamlis one entry via a new${HYPERCI_LLVM_DEFAULT}placeholder. A project'sbuild.rust.llvm_versionorHYPERCI_LLVM_VERSIONdoesn't change what the image bakes, though native-deps groups in the sameinstall-allstill follow the designated major.llvm-clangnative-deps group installsclang-NNat job time, but only for repos whose.cargo/config.tomllinks through clang. Every other Rust job is unchanged, so hosted runners don't pick up a new apt.llvm.org dependency or a different libclang.clang/clang++to the designated major, next to the existingld.lldshim. A clang that falls back to another major links with its own major's lld, and the warning says so.runtimes.llvmkey is a clean error rather than a traceback.windows/amd64is out of the Go default targets and theallshortcut. The explicitwindowsshortcut stays.No hyperi-infra Dockerfile change is needed. hyperi-infra#310 already points the alternatives at
runtime_version('llvm').Evidence:
hyperi-ci checkclean, 5479 tests passing. Reviewed by an adversarial pass with no P1, and every P2/P3 finding is fixed in this commit. Not done yet: a fixture rehearsal, and an image rebuild with this release.