Repository navigation
fix(python): remove the Nuitka build strategy - #525
Merged
Merged
Conversation
Nuitka was a holdover from before the CI went OSS, and the build function was a stub that always failed. The strategy branch in dispatch, the stub, its defaults comment and the doc mentions are gone. A config still naming the nuitka strategy now fails as an unknown build strategy, as it failed before. Closes #524.
Contributor
|
Released in v2.12.15 -- https://github.com/hyperi-io/hyperi-ci/releases/tag/v2.12.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524. Nuitka was a holdover from before the CI went OSS. It comes out before GA.
_build_nuitkawas a stub that always returned 1, so this removes dead code: the stub, thenuitkabranch indispatch.py, the defaults.yaml comment and four doc mentions.nuitkanow fails as an unknown build strategy. It failed before too.hyperi-ci check --quickis clean. 436 dispatch and build tests pass.NUITKA_SSH_KEYgoes with Retire unused org Actions secrets and variables (after DFE 2.2 GA) #517.