Skip to content

docs: describe the clickhouse fork pin as it is - #245

Merged
catinspace-au merged 1 commit into
mainfrom
docs/clickhouse-fork-pin
Oct 10, 2026
Merged

catinspace-au merged 1 commit into
mainfrom
docs/clickhouse-fork-pin

Conversation

@catinspace-au

Copy link
Copy Markdown
Contributor

Two doc corrections, no code.

  • CLICKHOUSE-EXT.md said the fork is pinned to an immutable tag. Cargo.toml:300 pins rev 6f9acd96, the tip of hyperi-port/06d-tcp-tls-new, and none of the fork's 30 tags points at it. The fork repo is archived, so the branch can no longer move and the rev stays reachable. It also means retiring the patch (Pre-GA bug sweep: the clickhouse patch #133) is the only way a client fix lands.
  • INSERT-FORMATS.md: "ten rows written for UInt8 are 90 bytes" only adds up with the UInt64 id column (9 bytes a row). It now says ten (id UInt64, v UInt8) rows, read by an (id UInt64, v UInt16) table as nine rows.

CLICKHOUSE-EXT.md said the fork is pinned to an immutable tag. Cargo.toml pins a rev at the tip of hyperi-port/06d-tcp-tls-new, and no tag points at it. The fork repo is archived, so that branch can no longer be force-pushed and the rev stays reachable, but no fix can land there either (#133).

INSERT-FORMATS.md's 90-byte example now names the UInt64 id column the arithmetic depends on.
@catinspace-au
catinspace-au merged commit c746bf7 into main Oct 10, 2026
10 checks passed
@catinspace-au
catinspace-au deleted the docs/clickhouse-fork-pin branch October 10, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant