Repository navigation
fix: make a VM update survive its first start - #209
Merged
Merged
Conversation
An update on an existing VM failed for two reasons. - The updater never ran `make init`, so an .env from an older version was missing the three secrets 2.2.0 generates (DFE_HUNT_RUNNER_CLICKHOUSE_PASSWORD, HYPERDX_EXPRESS_SESSION_SECRET, HYPERDX_TOKEN_ENCRYPTION_KEY) and the self test refused them. It now runs `make init` first, which only tops up missing keys and never overwrites one. - On an empty volume the engine creates every ClickHouse table before /readyz answers. That took about 76s against an 80s healthcheck budget, so compose could give up seconds before the engine was ready. start_period goes from 30s to 180s. A warm start still reports healthy on its first passing probe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update on an existing VM failed for two reasons.
make init, so an .env from an older version was missing the three secrets 2.2.0 generates and the self test refused them. It now runsmake initfirst, which only tops up missing keys and never overwrites one.Local: check-compose, check-hardfail, check-python and check-tests green (772 passed, two new tests pin the update command order).
Done when the 2.2.0 update on the dfe-docker VM passes
make ciend to end.