Repository navigation
fix: drop the metrics manifest URL the engine no longer reads - #203
Merged
Merged
Conversation
dfe-engine #742 removed the service-surfaces registry and its metrics refresh, the only reader of DFE_SERVICES_METRICS_MANIFEST_URL. The compose env line, the configuration doc paragraph and scripts/tests/test_metrics_manifest.py go with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dfe-engine #742 (merged, 3418a6d) removed
/api/v1/service-surfacesand its metrics refresh. That was the only reader ofDFE_SERVICES_METRICS_MANIFEST_URL, so the compose env line, the doc paragraph describing the refresh, andscripts/tests/test_metrics_manifest.pygo too.An engine image that still has the refresh treats the variable as unset and answers
refreshed: false, so this is safe against either image.Locally: make check-compose, check-docs, check-hardfail clean. check-profiles against the matching dfe-infra branch (#527) up to date.
pytest scripts/tests762 passed.