Skip to content

chore: remove committed PR previews - #320

Merged
hyochan merged 1 commit into
mainfrom
chore/repo-pr-preview-cleanup
Aug 13, 2026
Merged

hyochan merged 1 commit into
mainfrom
chore/repo-pr-preview-cleanup

Conversation

@hyochan

@hyochan hyochan commented Aug 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Move the 19 tracked PR preview assets to GitHub user attachments in their original PR bodies or comments.
  • Remove .github/pr-previews from version control.
  • Require temporary local recordings and direct GitHub uploads; blocked uploads now stop for permission instead of force-adding a Git fallback.

Verification

  • All 20 migrated attachments, including PR fix(security): make the SBOM workflow able to describe any release tag #319, return the expected media type through ranged HTTP requests.
  • All 22 affected PR body/comment locations reference their new user-attachments URLs.
  • bun audit:docs
  • bun audit:parity
  • bun run audit:release-state
  • Prettier check for the edited source guidance
  • git diff --check

Preview

Not applicable: this removes repository-only review media and changes internal contribution guidance. The attachment and reference checks above are the relevant proof.

Summary by CodeRabbit

  • Documentation
    • Updated preview-sharing guidance to require temporary recordings to be uploaded as attachments and deleted afterward.
    • Prohibited committing one-off preview recordings as fallback assets.
    • Added instructions to stop and request maintainer assistance when attachment uploads are unavailable.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a097cbc5-a5eb-4869-8af8-5c3aa0e46739

📥 Commits

Reviewing files that changed from the base of the PR and between ce9ec53 and a5db0d0.

⛔ Files ignored due to path filters (19)
  • .github/pr-previews/claude-parity-docs-preview.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/deprecations-3-0-migration.png is excluded by !**/*.png
  • .github/pr-previews/ecosystem-onside-preview.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/iapkit-asc-review-submission.jpg is excluded by !**/*.jpg
  • .github/pr-previews/issue-223-language-preference.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/july-2026-release-notes.png is excluded by !**/*.png
  • .github/pr-previews/open-redeem-offer-code-android.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/openiap-codegen-ssot.jpg is excluded by !**/*.jpg
  • .github/pr-previews/openiap-product-client-payload-preview.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/openiap-purchase-safety-audit.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/pr-256-major-api-removal.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/pr-265-app-store-toolchain.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/pr-281-setup-readability-expo.jpg is excluded by !**/*.jpg
  • .github/pr-previews/pr-281-setup-readability-flutter.jpg is excluded by !**/*.jpg
  • .github/pr-previews/pr-281-setup-readability-react-native.jpg is excluded by !**/*.jpg
  • .github/pr-previews/pr-313-kit-store-verification-ui.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/pr-316-ecosystem-removal.mp4 is excluded by !**/*.mp4
  • .github/pr-previews/pr-318-security-docs.webm is excluded by !**/*.webm
  • .github/pr-previews/pr-consolidated-framework-patches.mp4 is excluded by !**/*.mp4
📒 Files selected for processing (4)
  • .claude/commands/commit.md
  • .codex/skills/openiap-workflows/SKILL.md
  • knowledge/_claude-context/context.md
  • knowledge/internal/06-git-deployment.md

📝 Walkthrough

Walkthrough

The PR updates preview recording guidance across command instructions, workflow skills, generated context, and deployment documentation. Recordings must use temporary or ignored paths, upload as GitHub attachments, be verified and deleted, and require maintainer intervention when uploads are blocked.

Changes

Preview recording policy

Layer / File(s) Summary
Attachment-based preview workflow
.claude/commands/commit.md, .codex/skills/openiap-workflows/SKILL.md, knowledge/_claude-context/context.md, knowledge/internal/06-git-deployment.md
The guidance prohibits committed preview recordings. It requires temporary or ignored local files, GitHub attachment uploads, verification, deletion, and maintainer escalation when uploads are blocked. The generated-context timestamp is updated.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to a5db0

This PR removes committed preview media and updates contribution guidance; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: removing committed PR preview assets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/repo-pr-preview-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyochan hyochan added 📖 documentation Improvements or additions to documentation 🕶️ meta labels Aug 13, 2026
@hyochan
hyochan merged commit b73ca15 into main Aug 13, 2026
12 checks passed
@hyochan
hyochan deleted the chore/repo-pr-preview-cleanup branch August 13, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation 🕶️ meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant