docs: track apple readme badge from versions ssot - #279
Conversation
The apple version badge pinned a `filter=2.*` tag glob, so it kept showing v2.4.4 forever after the 3.x releases while the CocoaPods badge beside it showed v3.0.1. It now reads `$.apple` from openiap-versions.json with the same dynamic-json pattern the spec badge already uses, so a future major bump can never strand it again. Also align the kit line with the fair-use wording adopted across the repo in #269, and list packages/mcp-server, which the "all OpenIAP packages" section omitted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughREADME.md updates the Apple version badge, Kit’s free-use description, and the Packages list. ChangesREADME package and offering updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
28-28: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider adding a version or CI badge for consistency.
Every other package entry in this list (spec, google, apple, kit) includes at least one badge (CI status, version, or Maven). The new
mcp-serverentry has none. Add a CI or npm version badge if one is available, to keep the list visually consistent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 28, Add a CI status or npm version badge to the mcp-server entry in the package list, using an available badge source and matching the badge style used by the existing spec, google, apple, and kit entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.md`:
- Line 28: Add a CI status or npm version badge to the mcp-server entry in the
package list, using an available badge source and matching the badge style used
by the existing spec, google, apple, and kit entries.
The bug
The root README's apple version badge pinned a
filter=2.*tag glob, so itkept rendering v2.4.4 forever after the 3.x releases while the CocoaPods
badge right beside it showed v3.0.1.
The fix
The badge now reads
$.applefromopeniap-versions.jsonusing the samedynamic-json pattern the spec badge on the previous line already uses, so a
future major bump can never strand it again. Verified against the live
shields endpoint: the new badge renders v3.0.1, matching the SSOT and
the CocoaPods badge. (
packages/apple/README.mduses a digit glob and isnot affected.)
Also
("Free for everyone." predates that change).
packages/mcp-server— the section says "all OpenIAP packages" butomitted it.
README-only change.
🤖 Generated with Claude Code
Summary by CodeRabbit