Skip to content

kit: CI coverage gate excludes convex verifiers — all four store lanes unmeasured #312

Description

@hyochan

Third issue from the internal per-store lane audit (see #310, #311).

packages/kit's coverage gate measures only the HTTP shell: test:coverage passes --coverage.include='server/**/*.ts' and deploy-kit.yml enforces 90% line coverage on that lcov. The convex/ tree — where the actual per-store verification logic lives — is entirely outside the measured and enforced set.

Measured per-file statement coverage for the verifiers (vitest v8, full suite green at 1088 tests):

File Stmts Branch
convex/purchases/android.ts 54.5% —
convex/purchases/amazon.ts 23.2% 18.9%
convex/purchases/ios.ts 8.1% 10.4%
convex/purchases/horizon.ts 9.5% 0.0%

The server/api/v1 layer sits at 88–93% and passes the gate while the verify-action bodies (upstream HTTP call, status-code mapping, persistence) are dead-reckoned.

Suggested steps:

🤖 Findings from an internal multi-agent audit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kitIAPKit (receipt-validation SaaS)💨 ciCloud integration🧪 testIssue or pr related to testing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions