Third issue from the internal per-store lane audit (see #310, #311).
packages/kit's coverage gate measures only the HTTP shell: test:coverage passes --coverage.include='server/**/*.ts' and deploy-kit.yml enforces 90% line coverage on that lcov. The convex/ tree — where the actual per-store verification logic lives — is entirely outside the measured and enforced set.
Measured per-file statement coverage for the verifiers (vitest v8, full suite green at 1088 tests):
| File |
Stmts |
Branch |
convex/purchases/android.ts |
54.5% |
— |
convex/purchases/amazon.ts |
23.2% |
18.9% |
convex/purchases/ios.ts |
8.1% |
10.4% |
convex/purchases/horizon.ts |
9.5% |
0.0% |
The server/api/v1 layer sits at 88–93% and passes the gate while the verify-action bodies (upstream HTTP call, status-code mapping, persistence) are dead-reckoned.
Suggested steps:
🤖 Findings from an internal multi-agent audit.
Third issue from the internal per-store lane audit (see #310, #311).
packages/kit's coverage gate measures only the HTTP shell:test:coveragepasses--coverage.include='server/**/*.ts'anddeploy-kit.ymlenforces 90% line coverage on that lcov. Theconvex/tree — where the actual per-store verification logic lives — is entirely outside the measured and enforced set.Measured per-file statement coverage for the verifiers (vitest v8, full suite green at 1088 tests):
convex/purchases/android.tsconvex/purchases/amazon.tsconvex/purchases/ios.tsconvex/purchases/horizon.tsThe
server/api/v1layer sits at 88–93% and passes the gate while the verify-action bodies (upstream HTTP call, status-code mapping, persistence) are dead-reckoned.Suggested steps:
convex/**/*.tsto the coverage include set (excluding_generated)amazon.tsandhorizon.ts(status ladders, retry/timeout, failure persistence) — concrete gaps listed in kit: Horizon subscription lane is structurally broken and can corrupt Google Play subscriptions #310/kit: harden the Amazon RVS lane — sandbox bypass, expiry assumption, state staleness #311routes.test.ts:88-95)🤖 Findings from an internal multi-agent audit.